runtime/vm/parser.cc - Issue 1289813005: Use Object::null_instance and Object::null_function and do not create Handles everytime.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/parser.cc

Issue 1289813005: Use Object::null_instance and Object::null_function and do not create Handles everytime. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: code-review-patch Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/parser.cc

diff --git a/runtime/vm/parser.cc b/runtime/vm/parser.cc

index 3613166871cd1f5f83b92d16da9dbddc6c58c212..824c35ee45e173c6fb9709453c684cad24a55885 100644

--- a/runtime/vm/parser.cc

+++ b/runtime/vm/parser.cc

@@ -5405,7 +5405,7 @@ void Parser::ParseTopLevelVariable(TopLevel* top_level,

field = Field::New(var_name, is_static, is_final, is_const, is_reflectable,

current_class(), name_pos);

field.set_type(type);

- field.set_value(Instance::Handle(Z, Instance::null()));

+ field.set_value(Object::null_instance());

top_level->fields.Add(field);

library_.AddObject(field, var_name);

if (metadata_pos >= 0) {

« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »