Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issue 1289733003: Update font fallbacks for Win10 (Closed)

Created:
5 years, 4 months ago by scottmg
Modified:
5 years, 4 months ago
Reviewers:
eae
CC:
blink-reviews, krit, drott+blinkwatch_chromium.org, Rik, dshwang, jbroman, Justin Novosad, danakj, pdr+graphicswatchlist_chromium.org, f(malita), Stephen Chennney, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Update font fallbacks for Win10 The list of default-available fonts has changed on Windows 10, so for infrequently used fonts, we fail and render boxes. Update the fallbacks based on: https://msdn.microsoft.com/library/windows/apps/hh700394.aspx Languages that are fixed include: Sinhala, Lao, Tigrinya, Malayalam, Khmer, Amharic, Eritrean, Oriya, and maybe a few more related ones. TEST=On Win10 visit pages like http://www.omniglot.com/language/phrases/welcome.htm and http://www.omniglot.com/language/phrases/hello.htm and see there's no "missing character" boxes. R=eae@chromium.org BUG=516209 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200582

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -11 lines) Patch
M Source/platform/fonts/win/FontFallbackWin.cpp View 1 4 chunks +16 lines, -11 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
scottmg
5 years, 4 months ago (2015-08-14 04:11:09 UTC) #2
eae
LGTM Thanks Scott!
5 years, 4 months ago (2015-08-14 14:48:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289733003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289733003/60001
5 years, 4 months ago (2015-08-14 19:17:29 UTC) #6
scottmg
I moved the CJK additions to the end of their respective lists.
5 years, 4 months ago (2015-08-14 19:18:25 UTC) #8
eae
Still LGTM
5 years, 4 months ago (2015-08-14 19:41:03 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/93508)
5 years, 4 months ago (2015-08-14 21:51:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289733003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289733003/60001
5 years, 4 months ago (2015-08-14 21:58:42 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-15 00:19:24 UTC) #14
Message was sent while issue was closed.
Committed patchset #2 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200582

Powered by Google App Engine
This is Rietveld 408576698