Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: Source/bindings/v8/custom/V8PromiseCustom.cpp

Issue 128973003: Update bindings classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/custom/V8CustomXPathNSResolver.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/custom/V8PromiseCustom.cpp
diff --git a/Source/bindings/v8/custom/V8PromiseCustom.cpp b/Source/bindings/v8/custom/V8PromiseCustom.cpp
index eeabb25ce2dbbde2fdceb4f9f0e2c878957ebce1..657647def5ef4c458825c74de04b51cee8565b41 100644
--- a/Source/bindings/v8/custom/V8PromiseCustom.cpp
+++ b/Source/bindings/v8/custom/V8PromiseCustom.cpp
@@ -190,7 +190,7 @@ void addToDerived(v8::Handle<v8::Object> internal, v8::Handle<v8::Object> derive
ASSERT(fulfillCallbacks->Length() == rejectCallbacks->Length() && rejectCallbacks->Length() == derivedPromises->Length());
}
-class CallHandlerTask : public ExecutionContextTask {
+class CallHandlerTask FINAL : public ExecutionContextTask {
public:
CallHandlerTask(v8::Handle<v8::Object> promise, v8::Handle<v8::Function> handler, v8::Handle<v8::Value> argument, v8::Isolate* isolate, ExecutionContext* context)
: m_promise(isolate, promise)
@@ -231,7 +231,7 @@ void CallHandlerTask::performTask(ExecutionContext* context)
}
}
-class UpdateDerivedTask : public ExecutionContextTask {
+class UpdateDerivedTask FINAL : public ExecutionContextTask {
public:
UpdateDerivedTask(v8::Handle<v8::Object> promise, v8::Handle<v8::Function> onFulfilled, v8::Handle<v8::Function> onRejected, v8::Handle<v8::Object> originatorValueObject, v8::Isolate* isolate, ExecutionContext* context)
: m_promise(isolate, promise)
« no previous file with comments | « Source/bindings/v8/custom/V8CustomXPathNSResolver.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698