Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(186)

Unified Diff: Source/bindings/v8/PageScriptDebugServer.h

Issue 128973003: Update bindings classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/ExceptionStatePlaceholder.h ('k') | Source/bindings/v8/RetainedDOMInfo.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/PageScriptDebugServer.h
diff --git a/Source/bindings/v8/PageScriptDebugServer.h b/Source/bindings/v8/PageScriptDebugServer.h
index 78fde09e688e5a225230fdf503084d1a21a4c760..4a7078c1b66cb9229b43c8e20fb4708ab5c0c356 100644
--- a/Source/bindings/v8/PageScriptDebugServer.h
+++ b/Source/bindings/v8/PageScriptDebugServer.h
@@ -44,7 +44,7 @@ class ScriptController;
class ScriptPreprocessor;
class ScriptSourceCode;
-class PageScriptDebugServer : public ScriptDebugServer {
+class PageScriptDebugServer FINAL : public ScriptDebugServer {
WTF_MAKE_NONCOPYABLE(PageScriptDebugServer);
public:
static PageScriptDebugServer& shared();
@@ -60,21 +60,21 @@ public:
};
void setClientMessageLoop(PassOwnPtr<ClientMessageLoop>);
- virtual void compileScript(ScriptState*, const String& expression, const String& sourceURL, String* scriptId, String* exceptionMessage);
- virtual void clearCompiledScripts();
- virtual void runScript(ScriptState*, const String& scriptId, ScriptValue* result, bool* wasThrown, String* exceptionMessage);
- virtual void setPreprocessorSource(const String&);
- virtual void preprocessBeforeCompile(const v8::Debug::EventDetails&);
- virtual PassOwnPtr<ScriptSourceCode> preprocess(Frame*, const ScriptSourceCode&);
- virtual String preprocessEventListener(Frame*, const String& source, const String& url, const String& functionName);
+ virtual void compileScript(ScriptState*, const String& expression, const String& sourceURL, String* scriptId, String* exceptionMessage) OVERRIDE;
+ virtual void clearCompiledScripts() OVERRIDE;
+ virtual void runScript(ScriptState*, const String& scriptId, ScriptValue* result, bool* wasThrown, String* exceptionMessage) OVERRIDE;
+ virtual void setPreprocessorSource(const String&) OVERRIDE;
+ virtual void preprocessBeforeCompile(const v8::Debug::EventDetails&) OVERRIDE;
+ virtual PassOwnPtr<ScriptSourceCode> preprocess(Frame*, const ScriptSourceCode&) OVERRIDE;
+ virtual String preprocessEventListener(Frame*, const String& source, const String& url, const String& functionName) OVERRIDE;
private:
PageScriptDebugServer();
virtual ~PageScriptDebugServer() { }
- virtual ScriptDebugListener* getDebugListenerForContext(v8::Handle<v8::Context>);
- virtual void runMessageLoopOnPause(v8::Handle<v8::Context>);
- virtual void quitMessageLoopOnPause();
+ virtual ScriptDebugListener* getDebugListenerForContext(v8::Handle<v8::Context>) OVERRIDE;
+ virtual void runMessageLoopOnPause(v8::Handle<v8::Context>) OVERRIDE;
+ virtual void quitMessageLoopOnPause() OVERRIDE;
typedef HashMap<Page*, ScriptDebugListener*> ListenersMap;
ListenersMap m_listenersMap;
« no previous file with comments | « Source/bindings/v8/ExceptionStatePlaceholder.h ('k') | Source/bindings/v8/RetainedDOMInfo.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698