Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: Source/bindings/v8/V8CustomElementLifecycleCallbacks.h

Issue 128973003: Update bindings classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/v8/V8AbstractEventListener.h ('k') | Source/bindings/v8/V8ErrorHandler.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 28 matching lines...) Expand all
39 #include "wtf/PassRefPtr.h" 39 #include "wtf/PassRefPtr.h"
40 #include <v8.h> 40 #include <v8.h>
41 41
42 namespace WebCore { 42 namespace WebCore {
43 43
44 class CustomElementLifecycleCallbacks; 44 class CustomElementLifecycleCallbacks;
45 class Element; 45 class Element;
46 class ExecutionContext; 46 class ExecutionContext;
47 class V8PerContextData; 47 class V8PerContextData;
48 48
49 class V8CustomElementLifecycleCallbacks : public CustomElementLifecycleCallbacks , ContextLifecycleObserver { 49 class V8CustomElementLifecycleCallbacks FINAL : public CustomElementLifecycleCal lbacks, ContextLifecycleObserver {
50 public: 50 public:
51 static PassRefPtr<V8CustomElementLifecycleCallbacks> create(ExecutionContext *, v8::Handle<v8::Object> prototype, v8::Handle<v8::Function> created, v8::Handl e<v8::Function> attached, v8::Handle<v8::Function> detached, v8::Handle<v8::Func tion> attributeChanged); 51 static PassRefPtr<V8CustomElementLifecycleCallbacks> create(ExecutionContext *, v8::Handle<v8::Object> prototype, v8::Handle<v8::Function> created, v8::Handl e<v8::Function> attached, v8::Handle<v8::Function> detached, v8::Handle<v8::Func tion> attributeChanged);
52 52
53 virtual ~V8CustomElementLifecycleCallbacks(); 53 virtual ~V8CustomElementLifecycleCallbacks();
54 54
55 bool setBinding(CustomElementDefinition* owner, PassOwnPtr<CustomElementBind ing>); 55 bool setBinding(CustomElementDefinition* owner, PassOwnPtr<CustomElementBind ing>);
56 56
57 private: 57 private:
58 V8CustomElementLifecycleCallbacks(ExecutionContext*, v8::Handle<v8::Object> prototype, v8::Handle<v8::Function> created, v8::Handle<v8::Function> attached, v8::Handle<v8::Function> detached, v8::Handle<v8::Function> attributeChanged); 58 V8CustomElementLifecycleCallbacks(ExecutionContext*, v8::Handle<v8::Object> prototype, v8::Handle<v8::Function> created, v8::Handle<v8::Function> attached, v8::Handle<v8::Function> detached, v8::Handle<v8::Function> attributeChanged);
59 59
(...skipping 11 matching lines...) Expand all
71 ScopedPersistent<v8::Object> m_prototype; 71 ScopedPersistent<v8::Object> m_prototype;
72 ScopedPersistent<v8::Function> m_created; 72 ScopedPersistent<v8::Function> m_created;
73 ScopedPersistent<v8::Function> m_attached; 73 ScopedPersistent<v8::Function> m_attached;
74 ScopedPersistent<v8::Function> m_detached; 74 ScopedPersistent<v8::Function> m_detached;
75 ScopedPersistent<v8::Function> m_attributeChanged; 75 ScopedPersistent<v8::Function> m_attributeChanged;
76 }; 76 };
77 77
78 } 78 }
79 79
80 #endif // V8CustomElementLifecycleCallbacks_h 80 #endif // V8CustomElementLifecycleCallbacks_h
OLDNEW
« no previous file with comments | « Source/bindings/v8/V8AbstractEventListener.h ('k') | Source/bindings/v8/V8ErrorHandler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698