Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Side by Side Diff: Source/bindings/v8/RetainedDOMInfo.h

Issue 128973003: Update bindings classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/bindings/v8/PageScriptDebugServer.h ('k') | Source/bindings/v8/ScriptObject.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 20 matching lines...) Expand all
31 #ifndef RetainedDOMInfo_h 31 #ifndef RetainedDOMInfo_h
32 #define RetainedDOMInfo_h 32 #define RetainedDOMInfo_h
33 33
34 #include "bindings/v8/RetainedObjectInfo.h" 34 #include "bindings/v8/RetainedObjectInfo.h"
35 35
36 namespace WebCore { 36 namespace WebCore {
37 37
38 class Node; 38 class Node;
39 39
40 // Implements v8::RetainedObjectInfo. 40 // Implements v8::RetainedObjectInfo.
41 class RetainedDOMInfo : public RetainedObjectInfo { 41 class RetainedDOMInfo FINAL : public RetainedObjectInfo {
42 public: 42 public:
43 explicit RetainedDOMInfo(Node* root); 43 explicit RetainedDOMInfo(Node* root);
44 virtual ~RetainedDOMInfo(); 44 virtual ~RetainedDOMInfo();
45 virtual void Dispose(); 45 virtual void Dispose() OVERRIDE;
46 virtual bool IsEquivalent(v8::RetainedObjectInfo* other); 46 virtual bool IsEquivalent(v8::RetainedObjectInfo* other) OVERRIDE;
47 virtual intptr_t GetHash(); 47 virtual intptr_t GetHash() OVERRIDE;
48 virtual const char* GetGroupLabel(); 48 virtual const char* GetGroupLabel() OVERRIDE;
49 virtual const char* GetLabel(); 49 virtual const char* GetLabel() OVERRIDE;
50 virtual intptr_t GetElementCount(); 50 virtual intptr_t GetElementCount() OVERRIDE;
51 virtual intptr_t GetEquivalenceClass(); 51 virtual intptr_t GetEquivalenceClass() OVERRIDE;
52 52
53 private: 53 private:
54 // V8 guarantees to keep RetainedObjectInfos alive only during a GC or heap snapshotting round, when renderer 54 // V8 guarantees to keep RetainedObjectInfos alive only during a GC or heap snapshotting round, when renderer
55 // doesn't get control. This allows us to use raw pointers. 55 // doesn't get control. This allows us to use raw pointers.
56 Node* m_root; 56 Node* m_root;
57 }; 57 };
58 58
59 } // namespace WebCore 59 } // namespace WebCore
60 60
61 #endif // RetainedDOMInfo_h 61 #endif // RetainedDOMInfo_h
OLDNEW
« no previous file with comments | « Source/bindings/v8/PageScriptDebugServer.h ('k') | Source/bindings/v8/ScriptObject.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698