Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: Source/bindings/v8/ExceptionState.h

Issue 128973003: Update bindings classes to use OVERRIDE / FINAL when needed (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 109 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 void setException(v8::Handle<v8::Value>); 120 void setException(v8::Handle<v8::Value>);
121 121
122 String addExceptionContext(const String&) const; 122 String addExceptionContext(const String&) const;
123 123
124 ScopedPersistent<v8::Value> m_exception; 124 ScopedPersistent<v8::Value> m_exception;
125 v8::Handle<v8::Object> m_creationContext; 125 v8::Handle<v8::Object> m_creationContext;
126 v8::Isolate* m_isolate; 126 v8::Isolate* m_isolate;
127 }; 127 };
128 128
129 // Used if exceptions can/should not be directly thrown. 129 // Used if exceptions can/should not be directly thrown.
130 class NonThrowableExceptionState : public ExceptionState { 130 class NonThrowableExceptionState FINAL : public ExceptionState {
131 public: 131 public:
132 NonThrowableExceptionState(): ExceptionState(v8::Handle<v8::Object>(), v8::I solate::GetCurrent()) { } 132 NonThrowableExceptionState(): ExceptionState(v8::Handle<v8::Object>(), v8::I solate::GetCurrent()) { }
133 virtual void throwDOMException(const ExceptionCode&, const String& message) OVERRIDE FINAL; 133 virtual void throwDOMException(const ExceptionCode&, const String& message) OVERRIDE;
134 virtual void throwTypeError(const String& message = String()) OVERRIDE FINAL ; 134 virtual void throwTypeError(const String& message = String()) OVERRIDE;
135 virtual void throwSecurityError(const String& sanitizedMessage, const String & unsanitizedMessage = String()) OVERRIDE FINAL; 135 virtual void throwSecurityError(const String& sanitizedMessage, const String & unsanitizedMessage = String()) OVERRIDE;
136 }; 136 };
137 137
138 // Used if any exceptions thrown are ignorable. 138 // Used if any exceptions thrown are ignorable.
139 class TrackExceptionState : public ExceptionState { 139 class TrackExceptionState FINAL : public ExceptionState {
140 public: 140 public:
141 TrackExceptionState(): ExceptionState(v8::Handle<v8::Object>(), v8::Isolate: :GetCurrent()) { } 141 TrackExceptionState(): ExceptionState(v8::Handle<v8::Object>(), v8::Isolate: :GetCurrent()) { }
142 virtual void throwDOMException(const ExceptionCode&, const String& message) OVERRIDE FINAL; 142 virtual void throwDOMException(const ExceptionCode&, const String& message) OVERRIDE;
143 virtual void throwTypeError(const String& message = String()) OVERRIDE FINAL ; 143 virtual void throwTypeError(const String& message = String()) OVERRIDE;
144 virtual void throwSecurityError(const String& sanitizedMessage, const String & unsanitizedMessage = String()) OVERRIDE FINAL; 144 virtual void throwSecurityError(const String& sanitizedMessage, const String & unsanitizedMessage = String()) OVERRIDE;
145 }; 145 };
146 146
147 } // namespace WebCore 147 } // namespace WebCore
148 148
149 #endif // ExceptionState_h 149 #endif // ExceptionState_h
OLDNEW
« no previous file with comments | « Source/bindings/v8/CallbackPromiseAdapter.h ('k') | Source/bindings/v8/ExceptionStatePlaceholder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698