core/src/fpdfapi/fpdf_font/ttgsubtable.h - Issue 1289703003: FX_CMapDwordToDword considered harmful.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_font/ttgsubtable.h

Issue 1289703003: FX_CMapDwordToDword considered harmful. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Rebase, remove if(). Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_font/ttgsubtable.h

diff --git a/core/src/fpdfapi/fpdf_font/ttgsubtable.h b/core/src/fpdfapi/fpdf_font/ttgsubtable.h

index 67cda371c11fff4dbb37e1376a8bbc60660b44b4..5cf0e2413fa2a277cbc594de75bab23634ad578c 100644

--- a/core/src/fpdfapi/fpdf_font/ttgsubtable.h

+++ b/core/src/fpdfapi/fpdf_font/ttgsubtable.h

@@ -341,7 +341,7 @@ class CFX_CTTGSUBTable {

p += 4;

return ret;

}

- CFX_CMapDWordToDWord m_featureMap;

+ std::map<FX_DWORD, FX_DWORD> m_featureMap;

FX_BOOL m_bFeautureMapLoad;

bool loaded;

struct tt_gsub_header header;

« no previous file with comments | « core/src/fpdfapi/fpdf_font/fpdf_font.cpp ('k') | core/src/fpdfapi/fpdf_font/ttgsubtable.cpp » ('j') | no next file with comments »