core/src/fpdfapi/fpdf_font/font_int.h - Issue 1289703003: FX_CMapDwordToDword considered harmful.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fpdfapi/fpdf_font/font_int.h

Issue 1289703003: FX_CMapDwordToDword considered harmful. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Rebase, remove if(). Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fpdfapi/fpdf_font/font_int.h

diff --git a/core/src/fpdfapi/fpdf_font/font_int.h b/core/src/fpdfapi/fpdf_font/font_int.h

index 30223ad63ad59559958d95bf4c14f7eb857370ed..59acfcbd350951e4676b969d658c4bec62e8c7e3 100644

--- a/core/src/fpdfapi/fpdf_font/font_int.h

+++ b/core/src/fpdfapi/fpdf_font/font_int.h

@@ -172,7 +172,7 @@ class CPDF_ToUnicodeMap {

FX_DWORD ReverseLookup(FX_WCHAR unicode);

protected:

- CFX_CMapDWordToDWord m_Map;

+ std::map<FX_DWORD, FX_DWORD> m_Map;

CPDF_CID2UnicodeMap* m_pBaseMap;

CFX_WideTextBuf m_MultiCharBuf;

};

« no previous file with comments | « core/include/fxcrt/fx_basic.h ('k') | core/src/fpdfapi/fpdf_font/fpdf_font.cpp » ('j') | no next file with comments »