FX_CMapDwordToDword considered harmful.

core/src/fpdfapi/fpdf_font/fpdf_font.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../include/fpdfapi/fpdf_module.h"
 #include "../../../include/fpdfapi/fpdf_page.h"
 #include "../../../include/fpdfapi/fpdf_pageobj.h"
 #include "../../../include/fpdfapi/fpdf_resource.h"
@@ skipping 455 matching lines @@
 static CFX_ByteString _FontMap_GetByteString(CFX_CharMap* pMap,
                                              const CFX_WideString& widestr) {
   return ((CPDF_FontCharMap*)pMap)->m_pFont->EncodeString(widestr);
 }
 CPDF_FontCharMap::CPDF_FontCharMap(CPDF_Font* pFont) {
   m_GetByteString = _FontMap_GetByteString;
   m_GetWideString = _FontMap_GetWideString;
   m_pFont = pFont;
 }
 CFX_WideString CPDF_ToUnicodeMap::Lookup(FX_DWORD charcode) {
-  FX_DWORD value;
-  if (m_Map.Lookup(charcode, value)) {
+  auto it = m_Map.find(charcode);
+  if (it != m_Map.end()) {
+    FX_DWORD value = it->second;
     FX_WCHAR unicode = (FX_WCHAR)(value & 0xffff);
     if (unicode != 0xffff) {
       return unicode;
     }
     const FX_WCHAR* buf = m_MultiCharBuf.GetBuffer();
     FX_DWORD buf_len = m_MultiCharBuf.GetLength();
     if (buf == NULL || buf_len == 0) {
       return CFX_WideString();
     }
     FX_DWORD index = value >> 16;
     if (index >= buf_len) {
       return CFX_WideString();
     }
     FX_DWORD len = buf[index];
     if (index + len < index || index + len >= buf_len) {
       return CFX_WideString();
     }
     return CFX_WideString(buf + index + 1, len);
   }
   if (m_pBaseMap) {
     return m_pBaseMap->UnicodeFromCID((FX_WORD)charcode);
   }
   return CFX_WideString();
 }
 FX_DWORD CPDF_ToUnicodeMap::ReverseLookup(FX_WCHAR unicode) {
-  FX_POSITION pos = m_Map.GetStartPosition();
-  while (pos) {
-    FX_DWORD key, value;
-    m_Map.GetNextAssoc(pos, key, value);
-    if ((FX_WCHAR)value == unicode) {
-      return key;
-    }
+  for (const auto& pair : m_Map) {
+    if (pair.second == unicode)
+      return pair.first;
   }
   return 0;
 }
 static FX_DWORD _StringToCode(const CFX_ByteStringC& str) {
   const FX_CHAR* buf = str.GetCStr();
   int len = str.GetLength();
   if (len == 0) {
     return 0;
   }
   int result = 0;
@@ skipping 72 matching lines @@
   }
   if (buf[0] == '(') {
   }
   return result;
 }
 void CPDF_ToUnicodeMap::Load(CPDF_Stream* pStream) {
   int CIDSet = 0;
   CPDF_StreamAcc stream;
   stream.LoadAllData(pStream, FALSE);
   CPDF_SimpleParser parser(stream.GetData(), stream.GetSize());
-  m_Map.EstimateSize(stream.GetSize() / 8, 1024);
   while (1) {
     CFX_ByteStringC word = parser.GetWord();
     if (word.IsEmpty()) {
       break;
     }
     if (word == FX_BSTRC("beginbfchar")) {
       while (1) {
         word = parser.GetWord();
         if (word.IsEmpty() || word == FX_BSTRC("endbfchar")) {
           break;
         }
         FX_DWORD srccode = _StringToCode(word);
         word = parser.GetWord();
         CFX_WideString destcode = _StringToWideString(word);
         int len = destcode.GetLength();
         if (len == 0) {
           continue;
         }
         if (len == 1) {
-          m_Map.SetAt(srccode, destcode.GetAt(0));
+          m_Map[srccode] = destcode.GetAt(0);
         } else {
-          m_Map.SetAt(srccode, m_MultiCharBuf.GetLength() * 0x10000 + 0xffff);
+          m_Map[srccode] = m_MultiCharBuf.GetLength() * 0x10000 + 0xffff;
           m_MultiCharBuf.AppendChar(destcode.GetLength());
           m_MultiCharBuf << destcode;
         }
       }
     } else if (word == FX_BSTRC("beginbfrange")) {
       while (1) {
         CFX_ByteString low, high;
         low = parser.GetWord();
         if (low.IsEmpty() || low == FX_BSTRC("endbfrange")) {
           break;
         }
         high = parser.GetWord();
         FX_DWORD lowcode = _StringToCode(low);
         FX_DWORD highcode =
             (lowcode & 0xffffff00) | (_StringToCode(high) & 0xff);
         if (highcode == (FX_DWORD)-1) {
           break;
         }
         CFX_ByteString start = parser.GetWord();
         if (start == FX_BSTRC("[")) {
           for (FX_DWORD code = lowcode; code <= highcode; code++) {
             CFX_ByteString dest = parser.GetWord();
             CFX_WideString destcode = _StringToWideString(dest);
             int len = destcode.GetLength();
             if (len == 0) {
               continue;
             }
             if (len == 1) {
-              m_Map.SetAt(code, destcode.GetAt(0));
+              m_Map[code] = destcode.GetAt(0);
             } else {
-              m_Map.SetAt(code, m_MultiCharBuf.GetLength() * 0x10000 + 0xffff);
+              m_Map[code] = m_MultiCharBuf.GetLength() * 0x10000 + 0xffff;
               m_MultiCharBuf.AppendChar(destcode.GetLength());
               m_MultiCharBuf << destcode;
             }
           }
           parser.GetWord();
         } else {
           CFX_WideString destcode = _StringToWideString(start);
           int len = destcode.GetLength();
           FX_DWORD value = 0;
           if (len == 1) {
             value = _StringToCode(start);
             for (FX_DWORD code = lowcode; code <= highcode; code++) {
-              m_Map.SetAt(code, value++);
+              m_Map[code] = value++;
             }
           } else {
             for (FX_DWORD code = lowcode; code <= highcode; code++) {
               CFX_WideString retcode;
               if (code == lowcode) {
                 retcode = destcode;
               } else {
                 retcode = _StringDataAdd(destcode);
               }
-              m_Map.SetAt(code, m_MultiCharBuf.GetLength() * 0x10000 + 0xffff);
+              m_Map[code] = m_MultiCharBuf.GetLength() * 0x10000 + 0xffff;
               m_MultiCharBuf.AppendChar(retcode.GetLength());
               m_MultiCharBuf << retcode;
               destcode = retcode;
             }
           }
         }
       }
     } else if (word == FX_BSTRC("/Adobe-Korea1-UCS2")) {
       CIDSet = CIDSET_KOREA1;
     } else if (word == FX_BSTRC("/Adobe-Japan1-UCS2")) {
@@ skipping 1097 matching lines @@
 CPDF_Type3Char::CPDF_Type3Char() {
   m_pForm = NULL;
   m_pBitmap = NULL;
   m_bPageRequired = FALSE;
   m_bColored = FALSE;
 }
 CPDF_Type3Char::~CPDF_Type3Char() {
   delete m_pForm;
   delete m_pBitmap;
 }