OLD | NEW |
1 include_rules = [ | 1 include_rules = [ |
2 # Webdata is being made into a component (it will end up at | 2 # Webdata is being made into a component (it will end up at |
3 # //components/webdata and not depend on //chrome), so we have these basic | 3 # //components/webdata and not depend on //chrome), so we have these basic |
4 # rules followed by temporary exceptions. Please don't add to the list of | 4 # rules followed by temporary exceptions. Please don't add to the list of |
5 # exceptions! | 5 # exceptions! |
6 "-chrome/browser", | 6 "-chrome/browser", |
7 "-chrome/common", | 7 "-chrome/common", |
8 "+chrome/browser/api/webdata", | 8 "+chrome/browser/api/webdata", |
9 "+chrome/browser/webdata", | 9 "+chrome/browser/webdata", |
10 | 10 |
11 # TODO(caitkp, kaiwang): Bring this list to zero. | 11 # Ensure the files that are going to be componentized don't depend |
12 # Do not add to the list of temporarily-allowed dependencies below, | 12 # on the ones that aren't. |
13 # and please do not introduce more #includes of these files. | 13 "-chrome/browser/webdata/autocomplete_syncable_service.h", |
14 "!chrome/browser/history/history_database.h", | 14 "-chrome/browser/webdata/autofill_profile_syncable_service.h", |
| 15 "-chrome/browser/webdata/web_data_service_factory.h", |
| 16 "-chrome/browser/webdata/web_data_service.h", |
| 17 |
| 18 # TODO(caitkp): Bring this list to zero. |
15 "!chrome/browser/password_manager/encryptor.h", | 19 "!chrome/browser/password_manager/encryptor.h", |
16 "!chrome/browser/password_manager/ie7_password.h", | 20 "!chrome/browser/password_manager/ie7_password.h", |
17 "!chrome/browser/profiles/profile.h", | 21 "!chrome/browser/profiles/profile.h", |
18 "!chrome/browser/profiles/profile_dependency_manager.h", | |
19 "!chrome/browser/profiles/profile_keyed_service.h", | |
20 "!chrome/browser/profiles/profile_keyed_service_factory.h", | |
21 "!chrome/browser/profiles/profile_manager.h", | |
22 "!chrome/browser/profiles/refcounted_profile_keyed_service.h", | |
23 "!chrome/browser/profiles/refcounted_profile_keyed_service_factory.h", | |
24 "!chrome/browser/search_engines/search_terms_data.h", | |
25 "!chrome/browser/search_engines/template_url.h", | |
26 "!chrome/browser/search_engines/template_url_id.h", | |
27 "!chrome/browser/search_engines/template_url_service.h", | |
28 "!chrome/browser/ui/profile_error_dialog.h", | |
29 "!chrome/common/chrome_constants.h", | 22 "!chrome/common/chrome_constants.h", |
| 23 "!chrome/common/chrome_paths.h", |
| 24 |
| 25 # TODO(caitkp): Remove this, at slightly lower priority - this is |
| 26 # just a set of header-only enums, so we can live with it |
| 27 # temporarily even after we componentize. |
30 "!chrome/common/chrome_notification_types.h", | 28 "!chrome/common/chrome_notification_types.h", |
31 "!chrome/common/chrome_paths.h", | |
32 # Do not add to the list of temporarily-allowed dependencies above, | |
33 # and please do not introduce more #includes of these files. | |
34 ] | 29 ] |
| 30 |
| 31 specific_include_rules = { |
| 32 # These files are staying in //chrome, so no need to restrict. |
| 33 |
| 34 r'((autocomplete|autofill_profile)_syncable_service|web_data_service(_win)?(_fac
tory)?)(_unittest)?\.(cc|h)': |
| 35 [ |
| 36 '+chrome/browser', |
| 37 '+chrome/common', |
| 38 ], |
| 39 |
| 40 # TODO(caitkp): Componentize all the different tables. For now, we |
| 41 # write these rules so they don't add bad dependencies. |
| 42 r'^(?!autofill)[a-z_]+_table(_unittest)?\.(cc|h)': [ |
| 43 "!chrome/browser/history/history_database.h", |
| 44 "!chrome/browser/search_engines/search_terms_data.h", |
| 45 "!chrome/browser/search_engines/template_url.h", |
| 46 "!chrome/browser/search_engines/template_url_id.h", |
| 47 "!chrome/browser/search_engines/template_url_service.h", |
| 48 ], |
| 49 |
| 50 # TODO(caitkp): Extract unit tests from //chrome, at lower priority |
| 51 # than production code. |
| 52 r'(.*_unittest|.*_test_util)\.(cc|h)': [ |
| 53 "+chrome/browser/webdata/web_data_service.h", |
| 54 "+chrome/browser/webdata/web_data_service_factory.h", |
| 55 ], |
| 56 } |
OLD | NEW |