Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(781)

Unified Diff: runtime/vm/intrinsifier_x64.cc

Issue 1289643005: Rename accessors of class Field to make it more apparent as to what is being accessed - static fiel… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: self-code-review Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intrinsifier_x64.cc
diff --git a/runtime/vm/intrinsifier_x64.cc b/runtime/vm/intrinsifier_x64.cc
index b911a990b0fbc8fb9ea9fef0a9a8d80c15ee239a..c2dd2c25a4c37417b67828ed3ff4e76b286e50ad 100644
--- a/runtime/vm/intrinsifier_x64.cc
+++ b/runtime/vm/intrinsifier_x64.cc
@@ -1489,10 +1489,12 @@ void Intrinsifier::Random_nextState(Assembler* assembler) {
random_class.LookupStaticField(Symbols::_A()));
ASSERT(!random_A_field.IsNull());
ASSERT(random_A_field.is_const());
- const Instance& a_value = Instance::Handle(random_A_field.value());
+ const Instance& a_value = Instance::Handle(random_A_field.StaticFieldValue());
const int64_t a_int_value = Integer::Cast(a_value).AsInt64Value();
- __ movq(RAX, Address(RSP, + 1 * kWordSize)); // Receiver.
- __ movq(RBX, FieldAddress(RAX, state_field.Offset())); // Field '_state'.
+ // Receiver.
+ __ movq(RAX, Address(RSP, + 1 * kWordSize));
+ // Field '_state'.
+ __ movq(RBX, FieldAddress(RAX, state_field.InstanceFieldOffset()));
// Addresses of _state[0] and _state[1].
const intptr_t scale = Instance::ElementSizeFor(kTypedDataUint32ArrayCid);
const intptr_t offset = Instance::DataOffsetFor(kTypedDataUint32ArrayCid);

Powered by Google App Engine
This is Rietveld 408576698