Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(839)

Unified Diff: runtime/vm/intrinsifier_ia32.cc

Issue 1289643005: Rename accessors of class Field to make it more apparent as to what is being accessed - static fiel… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: self-code-review Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/vm/intrinsifier_ia32.cc
diff --git a/runtime/vm/intrinsifier_ia32.cc b/runtime/vm/intrinsifier_ia32.cc
index 1814d20bcde97beb3e0901a6669a786debeffe2f..c68977614131b140a4735726643ebe4f6ceae25d 100644
--- a/runtime/vm/intrinsifier_ia32.cc
+++ b/runtime/vm/intrinsifier_ia32.cc
@@ -1635,13 +1635,16 @@ void Intrinsifier::Random_nextState(Assembler* assembler) {
random_class.LookupStaticField(Symbols::_A()));
ASSERT(!random_A_field.IsNull());
ASSERT(random_A_field.is_const());
- const Instance& a_value = Instance::Handle(random_A_field.value());
+ const Instance& a_value =
+ Instance::Handle(random_A_field.StaticFieldValue());
const int64_t a_int_value = Integer::Cast(a_value).AsInt64Value();
// 'a_int_value' is a mask.
ASSERT(Utils::IsUint(32, a_int_value));
int32_t a_int32_value = static_cast<int32_t>(a_int_value);
- __ movl(EAX, Address(ESP, + 1 * kWordSize)); // Receiver.
- __ movl(EBX, FieldAddress(EAX, state_field.Offset())); // Field '_state'.
+ // Receiver.
+ __ movl(EAX, Address(ESP, + 1 * kWordSize));
+ // Field '_state'.
+ __ movl(EBX, FieldAddress(EAX, state_field.InstanceFieldOffset()));
// Addresses of _state[0] and _state[1].
const intptr_t scale = Instance::ElementSizeFor(kTypedDataUint32ArrayCid);
const intptr_t offset = Instance::DataOffsetFor(kTypedDataUint32ArrayCid);

Powered by Google App Engine
This is Rietveld 408576698