Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Unified Diff: runtime/lib/mirrors.cc

Issue 1289643005: Rename accessors of class Field to make it more apparent as to what is being accessed - static fiel… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: self-code-review Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/ast.h » ('j') | runtime/vm/flow_graph_builder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/lib/mirrors.cc
diff --git a/runtime/lib/mirrors.cc b/runtime/lib/mirrors.cc
index d68e758aa24f20963ac6c42fbdff122ce1938060..9df5911952d6fce124bf17c32e630cfa54e20057 100644
--- a/runtime/lib/mirrors.cc
+++ b/runtime/lib/mirrors.cc
@@ -602,7 +602,7 @@ static void VerifyMethodKindShifts() {
#define CHECK_KIND_SHIFT(name) \
field = cls.LookupField(String::Handle(String::New(#name))); \
ASSERT(!field.IsNull()); \
- value ^= field.value(); \
+ value ^= field.StaticFieldValue(); \
ASSERT(value.Value() == Mirrors::name);
MIRRORS_KIND_SHIFT_LIST(CHECK_KIND_SHIFT)
#undef CHECK_KIND_SHIFT
@@ -677,7 +677,7 @@ static RawInstance* InvokeLibraryGetter(const Library& library,
}
} else {
if (!field.IsUninitialized()) {
- return field.value();
+ return field.StaticFieldValue();
}
// An uninitialized field was found. Check for a getter in the field's
// owner classs.
@@ -754,7 +754,7 @@ static RawInstance* InvokeClassGetter(const Class& klass,
DartEntry::InvokeFunction(getter, Object::empty_array()));
return ReturnResult(result);
}
- return field.value();
+ return field.StaticFieldValue();
}
@@ -1620,7 +1620,7 @@ DEFINE_NATIVE_ENTRY(ClassMirror_invokeSetter, 4) {
UNREACHABLE();
}
- field.set_value(value);
+ field.SetStaticFieldValue(value);
return value.raw();
}
@@ -1917,7 +1917,7 @@ DEFINE_NATIVE_ENTRY(LibraryMirror_invokeSetter, 4) {
UNREACHABLE();
}
- field.set_value(value);
+ field.SetStaticFieldValue(value);
return value.raw();
}
« no previous file with comments | « no previous file | runtime/vm/ast.h » ('j') | runtime/vm/flow_graph_builder.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698