Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(865)

Side by Side Diff: runtime/vm/regexp_assembler_ir.cc

Issue 1289643005: Rename accessors of class Field to make it more apparent as to what is being accessed - static fiel… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: self-code-review Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/regexp_assembler_ir.h" 5 #include "vm/regexp_assembler_ir.h"
6 6
7 #include "vm/bit_vector.h" 7 #include "vm/bit_vector.h"
8 #include "vm/compiler.h" 8 #include "vm/compiler.h"
9 #include "vm/dart_entry.h" 9 #include "vm/dart_entry.h"
10 #include "vm/flow_graph_builder.h" 10 #include "vm/flow_graph_builder.h"
(...skipping 410 matching lines...) Expand 10 before | Expand all | Expand 10 after
421 const Field& word_character_field = Field::ZoneHandle(Z, 421 const Field& word_character_field = Field::ZoneHandle(Z,
422 regexp_class.LookupStaticField(Symbols::_wordCharacterMap())); 422 regexp_class.LookupStaticField(Symbols::_wordCharacterMap()));
423 ASSERT(!word_character_field.IsNull()); 423 ASSERT(!word_character_field.IsNull());
424 424
425 if (word_character_field.IsUninitialized()) { 425 if (word_character_field.IsUninitialized()) {
426 word_character_field.EvaluateInitializer(); 426 word_character_field.EvaluateInitializer();
427 } 427 }
428 ASSERT(!word_character_field.IsUninitialized()); 428 ASSERT(!word_character_field.IsUninitialized());
429 429
430 return new(Z) ConstantInstr( 430 return new(Z) ConstantInstr(
431 Instance::ZoneHandle(Z, word_character_field.value())); 431 Instance::ZoneHandle(Z, word_character_field.StaticFieldValue()));
432 } 432 }
433 433
434 434
435 ComparisonInstr* IRRegExpMacroAssembler::Comparison( 435 ComparisonInstr* IRRegExpMacroAssembler::Comparison(
436 ComparisonKind kind, PushArgumentInstr* lhs, PushArgumentInstr* rhs) { 436 ComparisonKind kind, PushArgumentInstr* lhs, PushArgumentInstr* rhs) {
437 Token::Kind strict_comparison = Token::kEQ_STRICT; 437 Token::Kind strict_comparison = Token::kEQ_STRICT;
438 Token::Kind intermediate_operator = Token::kILLEGAL; 438 Token::Kind intermediate_operator = Token::kILLEGAL;
439 switch (kind) { 439 switch (kind) {
440 case kEQ: 440 case kEQ:
441 intermediate_operator = Token::kEQ; 441 intermediate_operator = Token::kEQ;
(...skipping 1472 matching lines...) Expand 10 before | Expand all | Expand 10 after
1914 index_val, 1914 index_val,
1915 characters, 1915 characters,
1916 specialization_cid_, 1916 specialization_cid_,
1917 Scanner::kNoSourcePos)); 1917 Scanner::kNoSourcePos));
1918 } 1918 }
1919 1919
1920 1920
1921 #undef __ 1921 #undef __
1922 1922
1923 } // namespace dart 1923 } // namespace dart
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698