Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Side by Side Diff: runtime/vm/object_test.cc

Issue 1289643005: Rename accessors of class Field to make it more apparent as to what is being accessed - static fiel… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: self-code-review Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "platform/globals.h" 5 #include "platform/globals.h"
6 6
7 #include "vm/assembler.h" 7 #include "vm/assembler.h"
8 #include "vm/class_finalizer.h" 8 #include "vm/class_finalizer.h"
9 #include "vm/dart_api_impl.h" 9 #include "vm/dart_api_impl.h"
10 #include "vm/dart_entry.h" 10 #include "vm/dart_entry.h"
(...skipping 270 matching lines...) Expand 10 before | Expand all | Expand 10 after
281 const Array& one_fields = Array::Handle(Array::New(1)); 281 const Array& one_fields = Array::Handle(Array::New(1));
282 const String& field_name = String::Handle(Symbols::New("the_field")); 282 const String& field_name = String::Handle(Symbols::New("the_field"));
283 const Field& field = Field::Handle( 283 const Field& field = Field::Handle(
284 Field::New(field_name, false, false, false, true, one_field_class, 0)); 284 Field::New(field_name, false, false, false, true, one_field_class, 0));
285 one_fields.SetAt(0, field); 285 one_fields.SetAt(0, field);
286 one_field_class.SetFields(one_fields); 286 one_field_class.SetFields(one_fields);
287 one_field_class.Finalize(); 287 one_field_class.Finalize();
288 intptr_t header_size = sizeof(RawObject); 288 intptr_t header_size = sizeof(RawObject);
289 EXPECT_EQ(Utils::RoundUp((header_size + (1 * kWordSize)), kObjectAlignment), 289 EXPECT_EQ(Utils::RoundUp((header_size + (1 * kWordSize)), kObjectAlignment),
290 one_field_class.instance_size()); 290 one_field_class.instance_size());
291 EXPECT_EQ(header_size, field.Offset()); 291 EXPECT_EQ(header_size, field.InstanceFieldOffset());
292 EXPECT(!one_field_class.is_implemented()); 292 EXPECT(!one_field_class.is_implemented());
293 one_field_class.set_is_implemented(); 293 one_field_class.set_is_implemented();
294 EXPECT(one_field_class.is_implemented()); 294 EXPECT(one_field_class.is_implemented());
295 } 295 }
296 296
297 297
298 TEST_CASE(Smi) { 298 TEST_CASE(Smi) {
299 const Smi& smi = Smi::Handle(Smi::New(5)); 299 const Smi& smi = Smi::Handle(Smi::New(5));
300 Object& smi_object = Object::Handle(smi.raw()); 300 Object& smi_object = Object::Handle(smi.raw());
301 EXPECT(smi.IsSmi()); 301 EXPECT(smi.IsSmi());
(...skipping 4401 matching lines...) Expand 10 before | Expand all | Expand 10 after
4703 EXPECT(iterator.MoveNext()); 4703 EXPECT(iterator.MoveNext());
4704 object = iterator.CurrentKey(); 4704 object = iterator.CurrentKey();
4705 EXPECT_STREQ("z", object.ToCString()); 4705 EXPECT_STREQ("z", object.ToCString());
4706 object = iterator.CurrentValue(); 4706 object = iterator.CurrentValue();
4707 EXPECT_STREQ("5", object.ToCString()); 4707 EXPECT_STREQ("5", object.ToCString());
4708 4708
4709 EXPECT(!iterator.MoveNext()); 4709 EXPECT(!iterator.MoveNext());
4710 } 4710 }
4711 4711
4712 } // namespace dart 4712 } // namespace dart
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698