Rename accessors of class Field to make it more apparent as to what is being accessed - static fiel…

runtime/vm/flow_graph_builder.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/flow_graph_builder.h"
 
 #include "lib/invocation_mirror.h"
 #include "vm/ast_printer.h"
 #include "vm/bit_vector.h"
 #include "vm/class_finalizer.h"
@@ skipping 3785 matching lines @@
                                      kEmitStoreBarrier,
                                      node->token_pos());
   // Maybe initializing unboxed store.
   store->set_is_potential_unboxed_initialization(true);
   ReturnDefinition(store);
 }
 
 
 void EffectGraphVisitor::VisitLoadStaticFieldNode(LoadStaticFieldNode* node) {
   if (node->field().is_const()) {
-    ASSERT(node->field().value() != Object::sentinel().raw());
-    ASSERT(node->field().value() != Object::transition_sentinel().raw());
-    Definition* result =
-        new(Z) ConstantInstr(Instance::ZoneHandle(Z, node->field().value()));
+    ASSERT(node->field().StaticFieldValue() != Object::sentinel().raw());
+    ASSERT(node->field().StaticFieldValue() !=

[hausner, 2015/09/01 16:02:02]

field().StaticFieldValue() seems a bit redundant, with the word Field contained
twice.  I didn't have a problem with field().value().

[siva, 2015/09/03 23:32:09]

I have renamed this to StaticValue as suggested by Ryan.
I feel field().StaticValue() is more readable that field().value() which appears
to be like a regular accessor that we have for fields and  it could return
whatever is in value_ (offset or static value).

+           Object::transition_sentinel().raw());
+    Definition* result = new(Z) ConstantInstr(
+        Instance::ZoneHandle(Z, node->field().StaticFieldValue()));
     return ReturnDefinition(result);
   }
   Value* field_value = Bind(new(Z) ConstantInstr(node->field()));
   LoadStaticFieldInstr* load = new(Z) LoadStaticFieldInstr(field_value);
   ReturnDefinition(load);
 }
 
 
 Definition* EffectGraphVisitor::BuildStoreStaticField(
   StoreStaticFieldNode* node, bool result_is_needed) {
@@ skipping 855 matching lines @@
   Report::MessageF(Report::kBailout,
                    Script::Handle(function.script()),
                    function.token_pos(),
                    "FlowGraphBuilder Bailout: %s %s",
                    String::Handle(function.name()).ToCString(),
                    reason);
   UNREACHABLE();
 }
 
 }  // namespace dart