Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Side by Side Diff: runtime/vm/ast.h

Issue 1289643005: Rename accessors of class Field to make it more apparent as to what is being accessed - static fiel… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: self-code-review Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_AST_H_ 5 #ifndef VM_AST_H_
6 #define VM_AST_H_ 6 #define VM_AST_H_
7 7
8 #include "platform/assert.h" 8 #include "platform/assert.h"
9 #include "vm/allocation.h" 9 #include "vm/allocation.h"
10 #include "vm/growable_array.h" 10 #include "vm/growable_array.h"
(...skipping 1281 matching lines...) Expand 10 before | Expand all | Expand 10 after
1292 1292
1293 virtual AstNode* MakeAssignmentNode(AstNode* rhs); 1293 virtual AstNode* MakeAssignmentNode(AstNode* rhs);
1294 1294
1295 virtual bool IsPotentiallyConst() const { 1295 virtual bool IsPotentiallyConst() const {
1296 return field_.is_const(); 1296 return field_.is_const();
1297 } 1297 }
1298 1298
1299 virtual const Instance* EvalConstExpr() const { 1299 virtual const Instance* EvalConstExpr() const {
1300 ASSERT(field_.is_static()); 1300 ASSERT(field_.is_static());
1301 return !is_deferred_reference_ && field_.is_const() 1301 return !is_deferred_reference_ && field_.is_const()
1302 ? &Instance::ZoneHandle(field_.value()) 1302 ? &Instance::ZoneHandle(field_.StaticFieldValue())
1303 : NULL; 1303 : NULL;
1304 } 1304 }
1305 1305
1306 DECLARE_COMMON_NODE_FUNCTIONS(LoadStaticFieldNode); 1306 DECLARE_COMMON_NODE_FUNCTIONS(LoadStaticFieldNode);
1307 1307
1308 private: 1308 private:
1309 const Field& field_; 1309 const Field& field_;
1310 bool is_deferred_reference_; 1310 bool is_deferred_reference_;
1311 1311
1312 DISALLOW_IMPLICIT_CONSTRUCTORS(LoadStaticFieldNode); 1312 DISALLOW_IMPLICIT_CONSTRUCTORS(LoadStaticFieldNode);
(...skipping 703 matching lines...) Expand 10 before | Expand all | Expand 10 after
2016 const intptr_t try_index_; 2016 const intptr_t try_index_;
2017 2017
2018 DISALLOW_IMPLICIT_CONSTRUCTORS(InlinedFinallyNode); 2018 DISALLOW_IMPLICIT_CONSTRUCTORS(InlinedFinallyNode);
2019 }; 2019 };
2020 2020
2021 } // namespace dart 2021 } // namespace dart
2022 2022
2023 #undef DECLARE_COMMON_NODE_FUNCTIONS 2023 #undef DECLARE_COMMON_NODE_FUNCTIONS
2024 2024
2025 #endif // VM_AST_H_ 2025 #endif // VM_AST_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698