Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Side by Side Diff: runtime/vm/regexp_assembler_ir.cc

Issue 1289643005: Rename accessors of class Field to make it more apparent as to what is being accessed - static fiel… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: add-comment Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/raw_object_snapshot.cc ('k') | runtime/vm/snapshot.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/regexp_assembler_ir.h" 5 #include "vm/regexp_assembler_ir.h"
6 6
7 #include "vm/bit_vector.h" 7 #include "vm/bit_vector.h"
8 #include "vm/compiler.h" 8 #include "vm/compiler.h"
9 #include "vm/dart_entry.h" 9 #include "vm/dart_entry.h"
10 #include "vm/flow_graph_builder.h" 10 #include "vm/flow_graph_builder.h"
(...skipping 415 matching lines...) Expand 10 before | Expand all | Expand 10 after
426 const Field& word_character_field = Field::ZoneHandle(Z, 426 const Field& word_character_field = Field::ZoneHandle(Z,
427 regexp_class.LookupStaticField(Symbols::_wordCharacterMap())); 427 regexp_class.LookupStaticField(Symbols::_wordCharacterMap()));
428 ASSERT(!word_character_field.IsNull()); 428 ASSERT(!word_character_field.IsNull());
429 429
430 if (word_character_field.IsUninitialized()) { 430 if (word_character_field.IsUninitialized()) {
431 word_character_field.EvaluateInitializer(); 431 word_character_field.EvaluateInitializer();
432 } 432 }
433 ASSERT(!word_character_field.IsUninitialized()); 433 ASSERT(!word_character_field.IsUninitialized());
434 434
435 return new(Z) ConstantInstr( 435 return new(Z) ConstantInstr(
436 Instance::ZoneHandle(Z, word_character_field.value())); 436 Instance::ZoneHandle(Z, word_character_field.StaticValue()));
437 } 437 }
438 438
439 439
440 ComparisonInstr* IRRegExpMacroAssembler::Comparison( 440 ComparisonInstr* IRRegExpMacroAssembler::Comparison(
441 ComparisonKind kind, PushArgumentInstr* lhs, PushArgumentInstr* rhs) { 441 ComparisonKind kind, PushArgumentInstr* lhs, PushArgumentInstr* rhs) {
442 Token::Kind strict_comparison = Token::kEQ_STRICT; 442 Token::Kind strict_comparison = Token::kEQ_STRICT;
443 Token::Kind intermediate_operator = Token::kILLEGAL; 443 Token::Kind intermediate_operator = Token::kILLEGAL;
444 switch (kind) { 444 switch (kind) {
445 case kEQ: 445 case kEQ:
446 intermediate_operator = Token::kEQ; 446 intermediate_operator = Token::kEQ;
(...skipping 1472 matching lines...) Expand 10 before | Expand all | Expand 10 after
1919 index_val, 1919 index_val,
1920 characters, 1920 characters,
1921 specialization_cid_, 1921 specialization_cid_,
1922 Scanner::kNoSourcePos)); 1922 Scanner::kNoSourcePos));
1923 } 1923 }
1924 1924
1925 1925
1926 #undef __ 1926 #undef __
1927 1927
1928 } // namespace dart 1928 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/raw_object_snapshot.cc ('k') | runtime/vm/snapshot.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698