Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(740)

Side by Side Diff: runtime/vm/flow_graph_builder.cc

Issue 1289643005: Rename accessors of class Field to make it more apparent as to what is being accessed - static fiel… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: add-comment Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/debugger.cc ('k') | runtime/vm/flow_graph_type_propagator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/flow_graph_builder.h" 5 #include "vm/flow_graph_builder.h"
6 6
7 #include "lib/invocation_mirror.h" 7 #include "lib/invocation_mirror.h"
8 #include "vm/ast_printer.h" 8 #include "vm/ast_printer.h"
9 #include "vm/bit_vector.h" 9 #include "vm/bit_vector.h"
10 #include "vm/class_finalizer.h" 10 #include "vm/class_finalizer.h"
(...skipping 3786 matching lines...) Expand 10 before | Expand all | Expand 10 after
3797 kEmitStoreBarrier, 3797 kEmitStoreBarrier,
3798 node->token_pos()); 3798 node->token_pos());
3799 // Maybe initializing unboxed store. 3799 // Maybe initializing unboxed store.
3800 store->set_is_potential_unboxed_initialization(true); 3800 store->set_is_potential_unboxed_initialization(true);
3801 ReturnDefinition(store); 3801 ReturnDefinition(store);
3802 } 3802 }
3803 3803
3804 3804
3805 void EffectGraphVisitor::VisitLoadStaticFieldNode(LoadStaticFieldNode* node) { 3805 void EffectGraphVisitor::VisitLoadStaticFieldNode(LoadStaticFieldNode* node) {
3806 if (node->field().is_const()) { 3806 if (node->field().is_const()) {
3807 ASSERT(node->field().value() != Object::sentinel().raw()); 3807 ASSERT(node->field().StaticValue() != Object::sentinel().raw());
3808 ASSERT(node->field().value() != Object::transition_sentinel().raw()); 3808 ASSERT(node->field().StaticValue() !=
3809 Definition* result = 3809 Object::transition_sentinel().raw());
3810 new(Z) ConstantInstr(Instance::ZoneHandle(Z, node->field().value())); 3810 Definition* result = new(Z) ConstantInstr(
3811 Instance::ZoneHandle(Z, node->field().StaticValue()));
3811 return ReturnDefinition(result); 3812 return ReturnDefinition(result);
3812 } 3813 }
3813 Value* field_value = Bind(new(Z) ConstantInstr(node->field())); 3814 Value* field_value = Bind(new(Z) ConstantInstr(node->field()));
3814 LoadStaticFieldInstr* load = new(Z) LoadStaticFieldInstr(field_value); 3815 LoadStaticFieldInstr* load = new(Z) LoadStaticFieldInstr(field_value);
3815 ReturnDefinition(load); 3816 ReturnDefinition(load);
3816 } 3817 }
3817 3818
3818 3819
3819 Definition* EffectGraphVisitor::BuildStoreStaticField( 3820 Definition* EffectGraphVisitor::BuildStoreStaticField(
3820 StoreStaticFieldNode* node, bool result_is_needed) { 3821 StoreStaticFieldNode* node, bool result_is_needed) {
(...skipping 855 matching lines...) Expand 10 before | Expand all | Expand 10 after
4676 Report::MessageF(Report::kBailout, 4677 Report::MessageF(Report::kBailout,
4677 Script::Handle(function.script()), 4678 Script::Handle(function.script()),
4678 function.token_pos(), 4679 function.token_pos(),
4679 "FlowGraphBuilder Bailout: %s %s", 4680 "FlowGraphBuilder Bailout: %s %s",
4680 String::Handle(function.name()).ToCString(), 4681 String::Handle(function.name()).ToCString(),
4681 reason); 4682 reason);
4682 UNREACHABLE(); 4683 UNREACHABLE();
4683 } 4684 }
4684 4685
4685 } // namespace dart 4686 } // namespace dart
OLDNEW
« no previous file with comments | « runtime/vm/debugger.cc ('k') | runtime/vm/flow_graph_type_propagator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698