Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: runtime/vm/ast.h

Issue 1289643005: Rename accessors of class Field to make it more apparent as to what is being accessed - static fiel… (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: add-comment Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/vm/class_finalizer.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #ifndef VM_AST_H_ 5 #ifndef VM_AST_H_
6 #define VM_AST_H_ 6 #define VM_AST_H_
7 7
8 #include "platform/assert.h" 8 #include "platform/assert.h"
9 #include "vm/allocation.h" 9 #include "vm/allocation.h"
10 #include "vm/growable_array.h" 10 #include "vm/growable_array.h"
(...skipping 1293 matching lines...) Expand 10 before | Expand all | Expand 10 after
1304 1304
1305 virtual AstNode* MakeAssignmentNode(AstNode* rhs); 1305 virtual AstNode* MakeAssignmentNode(AstNode* rhs);
1306 1306
1307 virtual bool IsPotentiallyConst() const { 1307 virtual bool IsPotentiallyConst() const {
1308 return field_.is_const(); 1308 return field_.is_const();
1309 } 1309 }
1310 1310
1311 virtual const Instance* EvalConstExpr() const { 1311 virtual const Instance* EvalConstExpr() const {
1312 ASSERT(field_.is_static()); 1312 ASSERT(field_.is_static());
1313 return !is_deferred_reference_ && field_.is_const() 1313 return !is_deferred_reference_ && field_.is_const()
1314 ? &Instance::ZoneHandle(field_.value()) 1314 ? &Instance::ZoneHandle(field_.StaticValue())
1315 : NULL; 1315 : NULL;
1316 } 1316 }
1317 1317
1318 DECLARE_COMMON_NODE_FUNCTIONS(LoadStaticFieldNode); 1318 DECLARE_COMMON_NODE_FUNCTIONS(LoadStaticFieldNode);
1319 1319
1320 private: 1320 private:
1321 const Field& field_; 1321 const Field& field_;
1322 bool is_deferred_reference_; 1322 bool is_deferred_reference_;
1323 1323
1324 DISALLOW_IMPLICIT_CONSTRUCTORS(LoadStaticFieldNode); 1324 DISALLOW_IMPLICIT_CONSTRUCTORS(LoadStaticFieldNode);
(...skipping 703 matching lines...) Expand 10 before | Expand all | Expand 10 after
2028 const intptr_t try_index_; 2028 const intptr_t try_index_;
2029 2029
2030 DISALLOW_IMPLICIT_CONSTRUCTORS(InlinedFinallyNode); 2030 DISALLOW_IMPLICIT_CONSTRUCTORS(InlinedFinallyNode);
2031 }; 2031 };
2032 2032
2033 } // namespace dart 2033 } // namespace dart
2034 2034
2035 #undef DECLARE_COMMON_NODE_FUNCTIONS 2035 #undef DECLARE_COMMON_NODE_FUNCTIONS
2036 2036
2037 #endif // VM_AST_H_ 2037 #endif // VM_AST_H_
OLDNEW
« no previous file with comments | « runtime/lib/mirrors.cc ('k') | runtime/vm/class_finalizer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698