build/android/disable_gcc_lto.gypi - Issue 1289623006: build: On Android, disable LTO for specific targets only when targeting GCC.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/disable_gcc_lto.gypi

Issue 1289623006: build: On Android, disable LTO for specific targets only when targeting GCC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Clarify comment in build/common.gypi; add TODO to use -lto_library Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/android/disable_gcc_lto.gypi

diff --git a/build/android/disable_lto.gypi b/build/android/disable_gcc_lto.gypi

similarity index 72%

rename from build/android/disable_lto.gypi

rename to build/android/disable_gcc_lto.gypi

index e379cfd3199ae1f6fe0a6fd6e7d1782b7e205954..a733c7aa0fc87251eba6fcbd566c95de8c8bed54 100644

--- a/build/android/disable_lto.gypi

+++ b/build/android/disable_gcc_lto.gypi

@@ -2,13 +2,13 @@

# Use of this source code is governed by a BSD-style license that can be

# found in the LICENSE file.

-# This file is meant to be included to disable LTO on a target.

+# This file is meant to be included to disable GCC LTO on a target.

{

'target_conditions': [

['_toolset=="target"', {

'conditions': [

- ['OS=="android" and (use_lto==1 or use_lto_o2==1)', {

+ ['OS=="android" and clang==0 and (use_lto==1 or use_lto_o2==1)', {

'cflags!': [

'-flto',

'-ffat-lto-objects',

« no previous file with comments | « no previous file | build/android/disable_lto.gypi » ('j') | no next file with comments »