Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Side by Side Diff: skia/skia_library_opts.gyp

Issue 1289623006: build: On Android, disable LTO for specific targets only when targeting GCC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clarify comment in build/common.gypi; add TODO to use -lto_library Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « skia/skia.gyp ('k') | third_party/libwebp/libwebp.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This gyp file contains the platform-specific optimizations for Skia 5 # This gyp file contains the platform-specific optimizations for Skia
6 { 6 {
7 'variables': { 7 'variables': {
8 'skia_src_path': '../third_party/skia/src', 8 'skia_src_path': '../third_party/skia/src',
9 'includes': [ '../third_party/skia/gyp/opts.gypi' ], 9 'includes': [ '../third_party/skia/gyp/opts.gypi' ],
10 'include_dirs': [ 10 'include_dirs': [
(...skipping 16 matching lines...) Expand all
27 # separately as well. 27 # separately as well.
28 { 28 {
29 'target_name': 'skia_opts', 29 'target_name': 'skia_opts',
30 'type': 'static_library', 30 'type': 'static_library',
31 'includes': [ 31 'includes': [
32 'skia_common.gypi', 32 'skia_common.gypi',
33 '../build/android/increase_size_for_speed.gypi', 33 '../build/android/increase_size_for_speed.gypi',
34 # Disable LTO due to compiler error 34 # Disable LTO due to compiler error
35 # in mems_in_disjoint_alias_sets_p, at alias.c:393 35 # in mems_in_disjoint_alias_sets_p, at alias.c:393
36 # crbug.com/422255 36 # crbug.com/422255
37 '../build/android/disable_lto.gypi', 37 '../build/android/disable_gcc_lto.gypi',
38 ], 38 ],
39 'include_dirs': [ '<@(include_dirs)' ], 39 'include_dirs': [ '<@(include_dirs)' ],
40 'conditions': [ 40 'conditions': [
41 [ 'target_arch != "arm" and target_arch != "mipsel" and \ 41 [ 'target_arch != "arm" and target_arch != "mipsel" and \
42 target_arch != "arm64" and target_arch != "mips64el"', { 42 target_arch != "arm64" and target_arch != "mips64el"', {
43 # Chrome builds with -msse2 locally, so sse2_sources could in theory 43 # Chrome builds with -msse2 locally, so sse2_sources could in theory
44 # be in the regular skia target. But we need skia_opts for arm 44 # be in the regular skia target. But we need skia_opts for arm
45 # anyway, so putting sse2_sources here is simpler than making this 45 # anyway, so putting sse2_sources here is simpler than making this
46 # conditionally a type none target on x86. 46 # conditionally a type none target on x86.
47 'sources': [ '<@(sse2_sources)' ], 47 'sources': [ '<@(sse2_sources)' ],
(...skipping 137 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 ['target_arch == "arm" and (arm_neon == 1 or arm_neon_optional == 1)', { 185 ['target_arch == "arm" and (arm_neon == 1 or arm_neon_optional == 1)', {
186 'targets': [ 186 'targets': [
187 { 187 {
188 'target_name': 'skia_opts_neon', 188 'target_name': 'skia_opts_neon',
189 'type': 'static_library', 189 'type': 'static_library',
190 'includes': [ 190 'includes': [
191 'skia_common.gypi', 191 'skia_common.gypi',
192 '../build/android/increase_size_for_speed.gypi', 192 '../build/android/increase_size_for_speed.gypi',
193 # Disable LTO due to Neon issues 193 # Disable LTO due to Neon issues
194 # crbug.com/408997 194 # crbug.com/408997
195 '../build/android/disable_lto.gypi', 195 '../build/android/disable_gcc_lto.gypi',
196 ], 196 ],
197 'include_dirs': [ '<@(include_dirs)' ], 197 'include_dirs': [ '<@(include_dirs)' ],
198 'cflags!': [ 198 'cflags!': [
199 '-fno-omit-frame-pointer', 199 '-fno-omit-frame-pointer',
200 '-mfpu=vfp', # remove them all, just in case. 200 '-mfpu=vfp', # remove them all, just in case.
201 '-mfpu=vfpv3', 201 '-mfpu=vfpv3',
202 '-mfpu=vfpv3-d16', 202 '-mfpu=vfpv3-d16',
203 ], 203 ],
204 'cflags': [ 204 'cflags': [
205 '-mfpu=neon', 205 '-mfpu=neon',
206 '-fomit-frame-pointer', 206 '-fomit-frame-pointer',
207 ], 207 ],
208 'ldflags': [ 208 'ldflags': [
209 '-march=armv7-a', 209 '-march=armv7-a',
210 '-Wl,--fix-cortex-a8', 210 '-Wl,--fix-cortex-a8',
211 ], 211 ],
212 'sources': [ '<@(neon_sources)' ], 212 'sources': [ '<@(neon_sources)' ],
213 }, 213 },
214 ], 214 ],
215 }], 215 }],
216 ], 216 ],
217 } 217 }
OLDNEW
« no previous file with comments | « skia/skia.gyp ('k') | third_party/libwebp/libwebp.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698