Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Side by Side Diff: build/common.gypi

Issue 1289623006: build: On Android, disable LTO for specific targets only when targeting GCC. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Clarify comment in build/common.gypi; add TODO to use -lto_library Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/android/increase_size_for_speed.gypi ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 666 matching lines...) Expand 10 before | Expand all | Expand 10 after
677 677
678 # Automatically select platforms under ozone. Turn this off to 678 # Automatically select platforms under ozone. Turn this off to
679 # build only explicitly selected platforms. 679 # build only explicitly selected platforms.
680 'ozone_auto_platforms%': 1, 680 'ozone_auto_platforms%': 1,
681 681
682 # If this is set clang is used as host compiler, but not as target 682 # If this is set clang is used as host compiler, but not as target
683 # compiler. Always do this by default. 683 # compiler. Always do this by default.
684 'host_clang%': 1, 684 'host_clang%': 1,
685 685
686 # Variables to control Link-Time Optimization (LTO). 686 # Variables to control Link-Time Optimization (LTO).
687 # On Android, the variable use_lto enables LTO on code compiled with -Os, 687 # On Android, when using GCC LTO, the variable use_lto enables LTO on code
688 # and use_lto_o2 enables LTO on code compiled with -O2. On other 688 # compiled with -Os, and use_lto_o2 enables LTO on code compiled with -O2.
689 # platforms, use_lto enables LTO in all translation units, and use_lto_o2 689 # On other platforms (including Android with Clang), use_lto enables LTO
690 # has no effect. 690 # in all translation units, and use_lto_o2 has no effect.
691 # 691 #
692 # On Linux and Android, when using LLVM LTO, the script 692 # On Linux and Android, when using LLVM LTO, the script
693 # build/download_gold_plugin.py must be run to download a linker plugin. 693 # build/download_gold_plugin.py must be run to download a linker plugin.
694 # On Mac, LLVM needs to be built from scratch using 694 # On Mac, LLVM needs to be built from scratch using
695 # tools/clang/scripts/update.py and the absolute path to 695 # tools/clang/scripts/update.py and the absolute path to
696 # third_party/llvm-build/Release+Asserts/lib must be added to 696 # third_party/llvm-build/Release+Asserts/lib must be added to
697 # $DYLD_LIBRARY_PATH to pick up the right version of the linker plugin. 697 # $DYLD_LIBRARY_PATH to pick up the right version of the linker plugin.
698 # TODO(pcc): Teach build system to use -lto_library flag to specify path
699 # to linker plugin on Mac.
698 # 700 #
699 # On Android, the variables must *not* be enabled at the same time. 701 # On Android/GCC, the variables must *not* be enabled at the same time.
700 # In this case LTO would 'merge' the optimization flags at link-time 702 # In this case LTO would 'merge' the optimization flags at link-time
701 # which would lead to all code be optimized with -O2. See crbug.com/407544 703 # which would lead to all code be optimized with -O2. See crbug.com/407544
702 'use_lto%': 0, 704 'use_lto%': 0,
703 'use_lto_o2%': 0, 705 'use_lto_o2%': 0,
704 706
705 # Allowed level of identical code folding in the gold linker. 707 # Allowed level of identical code folding in the gold linker.
706 'gold_icf_level%': 'all', 708 'gold_icf_level%': 'all',
707 709
708 # Libxkbcommon usage. 710 # Libxkbcommon usage.
709 'use_xkbcommon%': 0, 711 'use_xkbcommon%': 0,
(...skipping 5606 matching lines...) Expand 10 before | Expand all | Expand 10 after
6316 # settings in target dicts. SYMROOT is a special case, because many other 6318 # settings in target dicts. SYMROOT is a special case, because many other
6317 # Xcode variables depend on it, including variables such as 6319 # Xcode variables depend on it, including variables such as
6318 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6320 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6319 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6321 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6320 # files to appear (when present) in the UI as actual files and not red 6322 # files to appear (when present) in the UI as actual files and not red
6321 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6323 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6322 # and therefore SYMROOT, needs to be set at the project level. 6324 # and therefore SYMROOT, needs to be set at the project level.
6323 'SYMROOT': '<(DEPTH)/xcodebuild', 6325 'SYMROOT': '<(DEPTH)/xcodebuild',
6324 }, 6326 },
6325 } 6327 }
OLDNEW
« no previous file with comments | « build/android/increase_size_for_speed.gypi ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698