Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1289623004: Every pixel ref gets its own mutex. (Closed)

Created:
5 years, 4 months ago by mtklein_C
Modified:
5 years, 4 months ago
Reviewers:
f(malita), reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Every pixel ref gets its own mutex. Seems like a memory-saving flourish follow up would be to use SkSpinlock. BUG=Florin's email. Committed: https://skia.googlesource.com/skia/+/7e6d9c032662d876e83eb8e7bffada7ae0409eed

Patch Set 1 #

Patch Set 2 : mutable #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -88 lines) Patch
M include/core/SkPixelRef.h View 1 4 chunks +2 lines, -5 lines 0 comments Download
M src/core/SkPixelRef.cpp View 7 chunks +4 lines, -77 lines 0 comments Download
M src/gpu/SkGrPixelRef.cpp View 2 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289623004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289623004/20001
5 years, 4 months ago (2015-08-13 20:42:18 UTC) #2
mtklein_C
5 years, 4 months ago (2015-08-13 20:43:38 UTC) #4
f(malita)
LGTM!
5 years, 4 months ago (2015-08-13 20:52:26 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-13 20:59:04 UTC) #7
reed1
lgtm
5 years, 4 months ago (2015-08-13 21:00:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289623004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289623004/20001
5 years, 4 months ago (2015-08-13 21:01:06 UTC) #10
commit-bot: I haz the power
5 years, 4 months ago (2015-08-13 21:02:09 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7e6d9c032662d876e83eb8e7bffada7ae0409eed

Powered by Google App Engine
This is Rietveld 408576698