Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
12896002:
Fix android build. (Closed)
|
Created:
7 years, 9 months ago by scroggo Modified:
7 years, 9 months ago CC:
skia-review_googlegroups.com Base URL:
https://skia.googlecode.com/svn/trunk Visibility:
Public. |
DescriptionFix android build.
Patch Set 1 #Patch Set 2 : #
Total comments: 2
Messages
Total messages: 22 (0 generated)
LGTM https://codereview.chromium.org/12896002/diff/2001/gyp/ports.gyp File gyp/ports.gyp (right): https://codereview.chromium.org/12896002/diff/2001/gyp/ports.gyp#newcode178 gyp/ports.gyp:178: '../src/ports/FontHostConfiguration_android.cpp', Do you mind re-alphabetizing this section?
https://codereview.chromium.org/12896002/diff/2001/gyp/ports.gyp File gyp/ports.gyp (right): https://codereview.chromium.org/12896002/diff/2001/gyp/ports.gyp#newcode178 gyp/ports.gyp:178: '../src/ports/FontHostConfiguration_android.cpp', On 2013/03/15 19:19:22, borenet wrote: > Do you mind re-alphabetizing this section? My next CL (https://codereview.chromium.org/12433020/) removes SkAshmemImageCache, so I don't think there's any need to move them. I can move FontHostConfiguration_android.cpp to the top in a later CL though.
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/12896002/2001
Failed to apply the patch. svn: Commit failed (details follow): svn: Temporarily unavailable
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/12896002/2001
Failed to apply the patch. svn: Commit failed (details follow): svn: Temporarily unavailable
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/12896002/2001
Failed to apply the patch. svn: Commit failed (details follow): svn: Temporarily unavailable
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/12896002/2001
Failed to apply the patch. svn: Commit failed (details follow): svn: Temporarily unavailable
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/12896002/2001
Failed to apply the patch. svn: Commit failed (details follow): svn: Temporarily unavailable
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/12896002/2001
Failed to apply the patch. svn: Commit failed (details follow): svn: Temporarily unavailable
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/12896002/2001
Failed to apply the patch. svn: Commit failed (details follow): svn: Temporarily unavailable
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/12896002/2001
Failed to apply the patch. svn: Commit failed (details follow): svn: Temporarily unavailable
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/12896002/2001
Failed to apply the patch. svn: Commit failed (details follow): svn: Temporarily unavailable
Message was sent while issue was closed.
committed as r8178 |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
