Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(709)

Unified Diff: chrome/browser/ui/search/instant_controller.h

Issue 12895007: Send onsubmit query down to the instant extended overlay page when a navigation is performed from t… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Check return value of UpdateSearchState. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_edit_model.cc ('k') | chrome/browser/ui/search/instant_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/search/instant_controller.h
diff --git a/chrome/browser/ui/search/instant_controller.h b/chrome/browser/ui/search/instant_controller.h
index 09db21d34428b842e7ad83f6c15c34ec1cdee633..b70d8677103786a0c092dd0674debb5a0a25b598 100644
--- a/chrome/browser/ui/search/instant_controller.h
+++ b/chrome/browser/ui/search/instant_controller.h
@@ -118,6 +118,10 @@ class InstantController : public InstantPage::Delegate,
const string16& user_text,
const string16& full_text);
+ // Called when the user navigates to a URL from the omnibox. This will send
+ // an onsubmit notification to the instant page.
+ void OmniboxNavigateToURL();
+
// The overlay WebContents. May be NULL. InstantController retains ownership.
content::WebContents* GetOverlayContents() const;
@@ -206,6 +210,8 @@ class InstantController : public InstantPage::Delegate,
FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest,
NavigationSuggestionIsDiscardedUponSearchSuggestion);
FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest,
+ NavigateToURLSuggestionHitEnterAndLookForSubmit);
+ FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest,
MiddleClickOnSuggestionOpensInNewTab);
FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, NTPIsPreloaded);
FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, PreloadedNTPIsUsedInNewTab);
@@ -215,7 +221,7 @@ class InstantController : public InstantPage::Delegate,
FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, UnrelatedSiteInstance);
FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, ValidatesSuggestions);
FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest,
- OmniboxCommitsWhenShownFullHeight);
+ OmniboxCommitsWhenShownFullHeight);
FRIEND_TEST_ALL_PREFIXES(InstantExtendedTest, LocalNTPIsNotLocalOverlay);
FRIEND_TEST_ALL_PREFIXES(InstantExtendedManualTest,
MANUAL_OmniboxFocusLoadsInstant);
« no previous file with comments | « chrome/browser/ui/omnibox/omnibox_edit_model.cc ('k') | chrome/browser/ui/search/instant_controller.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698