Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4816)

Unified Diff: chrome/browser/ui/omnibox/omnibox_edit_model.cc

Issue 12895007: Send onsubmit query down to the instant extended overlay page when a navigation is performed from t… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Don't send url. Only send for current tab. Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/omnibox/omnibox_edit_model.cc
diff --git a/chrome/browser/ui/omnibox/omnibox_edit_model.cc b/chrome/browser/ui/omnibox/omnibox_edit_model.cc
index 9794fae72cd2c540812bea37d1fb9089ca0a755a..1ce4a82d0416d5d8feb3f80202f816e03633f83d 100644
--- a/chrome/browser/ui/omnibox/omnibox_edit_model.cc
+++ b/chrome/browser/ui/omnibox/omnibox_edit_model.cc
@@ -707,6 +707,20 @@ void OmniboxEditModel::OpenMatch(const AutocompleteMatch& match,
base::TimeTicks::Now() - time_user_first_modified_omnibox_;
const GURL destination_url = autocomplete_controller_->
GetDestinationURL(match, query_formulation_time);
+
+ // If running with instant, notify the instant controller that a navigation
+ // is about to take place if we are navigating to a URL. This can be
+ // determined by inspecting the transition type. To ensure (for some value
+ // of ensure) that this is only done on Enter key press, check that the
+ // disposition is CURRENT_TAB. This is the same heuristic used by
+ // BrowserInstantController::OpenInstant
sreeram 2013/04/01 16:22:01 You can remove the cagey wording here. I believe c
robertshield 2013/04/01 18:14:49 Done.
+ if (match.transition == content::PAGE_TRANSITION_TYPED &&
+ disposition == CURRENT_TAB) {
+ InstantController* instant = controller_->GetInstant();
+ if (instant)
+ instant->OnNavigateToURL();
+ }
+
// This calls RevertAll again.
base::AutoReset<bool> tmp(&in_revert_, true);
controller_->OnAutocompleteAccept(destination_url, disposition,
« no previous file with comments | « no previous file | chrome/browser/ui/search/instant_controller.h » ('j') | chrome/browser/ui/search/instant_controller.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698