Send onsubmit query down to the instant extended overlay page when a navigation is performed from t…

chrome/browser/ui/omnibox/omnibox_edit_model.cc

Index: chrome/browser/ui/omnibox/omnibox_edit_model.cc
diff --git a/chrome/browser/ui/omnibox/omnibox_edit_model.cc b/chrome/browser/ui/omnibox/omnibox_edit_model.cc
index 9794fae72cd2c540812bea37d1fb9089ca0a755a..e606d4c6603b704140a909b845e50d37aae9870e 100644
--- a/chrome/browser/ui/omnibox/omnibox_edit_model.cc
+++ b/chrome/browser/ui/omnibox/omnibox_edit_model.cc
@@ -707,6 +707,14 @@ void OmniboxEditModel::OpenMatch(const AutocompleteMatch& match,
         base::TimeTicks::Now() - time_user_first_modified_omnibox_;
     const GURL destination_url = autocomplete_controller_->
         GetDestinationURL(match, query_formulation_time);
+
+    // If running with instant, notify the instant page that a navigation
+    // is about to take place. Note that only the user-entered content, not the
+    // full match should be sent down to avoid leaking autocompleted content.
+    InstantController* instant = controller_->GetInstant();
+    if (instant)
+      instant->OnNavigate(autocomplete_controller_->input().text());

[sreeram, 2013/03/26 17:43:46]

Instant may be showing a search results preview, in which case, this isn't
actually going to be a navigation. OnAutocompleteAccept() below will lead to
Instant intercepting it in CommitIfPossible(). So:
1. This comment and the OnNavigate() name are slightly misleading. Perhaps call
it OnSubmit() or OnMaybeNavigate() or such.
2. Instant shouldn't blindly send Submit() to the page in the implementation of
OnNavigate(), because that will end up sending two submit() events in the case
of the search results preview.

[robertshield, 2013/03/26 19:19:24]

I noticed that I can also call this code only when the transition type here is
PAGE_TRANSITION_TYPED which aiui is the case only when a URL is being navigated
too. What do you think of this approach (see latest patch)?

+
     // This calls RevertAll again.
     base::AutoReset<bool> tmp(&in_revert_, true);
     controller_->OnAutocompleteAccept(destination_url, disposition,