Send onsubmit query down to the instant extended overlay page when a navigation is performed from t…

chrome/renderer/searchbox/searchbox.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/searchbox/searchbox.h"
 
 #include "base/utf_string_conversions.h"
 #include "chrome/common/render_messages.h"
 #include "chrome/common/url_constants.h"
 #include "chrome/renderer/searchbox/searchbox_extension.h"
@@ skipping 176 matching lines @@
   selection_start_ = selection_start;
   selection_end_ = selection_end;
   if (render_view()->GetWebView() && render_view()->GetWebView()->mainFrame()) {
     DVLOG(1) << render_view() << " OnChange";
     extensions_v8::SearchBoxExtension::DispatchChange(
         render_view()->GetWebView()->mainFrame());
   }
 }
 
 void SearchBox::OnSubmit(const string16& query) {
-  query_ = query;
+  if (!query.empty()) {
+    query_ = query;
+  }
+
   verbatim_ = true;
   selection_start_ = selection_end_ = query_.size();

[sreeram, 2013/04/01 20:08:46]

Put all these other things also into the 'if' block. (I.e., don't modify any
state if |query| is empty).

Please also add a comment as to why:
// Submit() is called when the user hits Enter to commit the omnibox text.
// If |query| is non-blank, the user committed a search. If it's blank, the
// omnibox text was a URL, and the user is navigating to it, in which case
// we shouldn't update the |query_| or associated state.

[robertshield, 2013/04/08 16:02:47]

Done.

   if (render_view()->GetWebView() && render_view()->GetWebView()->mainFrame()) {
     DVLOG(1) << render_view() << " OnSubmit";
     extensions_v8::SearchBoxExtension::DispatchSubmit(
         render_view()->GetWebView()->mainFrame());
   }
   Reset();
 }
 
 void SearchBox::OnCancel(const string16& query) {
   query_ = query;
@@ skipping 158 matching lines @@
   if (render_view()->GetWebView() && render_view()->GetWebView()->mainFrame()) {
     extensions_v8::SearchBoxExtension::DispatchMostVisitedChanged(
         render_view()->GetWebView()->mainFrame());
   }
 }
 
 const std::vector<InstantMostVisitedItem>&
 SearchBox::GetMostVisitedItems() const {
   return most_visited_items_;
 }