Send onsubmit query down to the instant extended overlay page when a navigation is performed from t…

chrome/browser/ui/search/instant_controller.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/search/instant_controller.h"
 
 #include "base/metrics/histogram.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "base/utf_string_conversions.h"
@@ skipping 592 matching lines @@
   last_omnibox_text_ = full_text;
   last_user_text_ = user_text;
   last_suggestion_ = InstantSuggestion();
 
   if (instant_tab_)
     instant_tab_->CancelSelection(full_text);
   else
     overlay_->CancelSelection(full_text);
 }
 
+void InstantController::OnNavigateToURL() {
+  if (!extended_enabled_)
+    return;
+
+  if (instant_tab_)
+    instant_tab_->Submit(L"");

[sreeram, 2013/04/01 16:22:01]

Re-using the Submit() method causes a small problem that the method (in
searchbox.cc) will now overwrite searchbox.value with the query. If you don't
want to invent a new IPC (and I'm in favour of not adding new IPCs), you need to
special-case the empty query there.

[robertshield, 2013/04/01 18:14:49]

Ok, I prevented overwriting of the query_ field in Searchbox::OnSubmit when
called with an empty query string.

+
+  if (overlay_)
+    overlay_->Submit(L"");

[sreeram, 2013/04/01 16:22:01]

Remove this. We shouldn't need to send any such info to the overlay.

[robertshield, 2013/04/01 18:14:49]

Done.

+}
+
 content::WebContents* InstantController::GetOverlayContents() const {
   return overlay_ ? overlay_->contents() : NULL;
 }
 
 bool InstantController::IsOverlayingSearchResults() const {
   return model_.mode().is_search_suggestions() && IsFullHeight(model_) &&
          (last_match_was_search_ ||
           last_suggestion_.behavior == INSTANT_COMPLETE_NEVER);
 }
 
@@ skipping 956 matching lines @@
       // for instance, if the user types 'i' and the suggestion is 'INSTANT',
       // suggest 'nstant'. Otherwise, the user text really isn't a prefix, so
       // suggest nothing.
       // TODO(samarth|jered): revisit this logic. http://crbug.com/196572.
       return true;
     }
   }
 
   return false;
 }