Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1289483002: move some public headers into private (Closed)

Created:
5 years, 4 months ago by reed2
Modified:
5 years, 4 months ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

move some public headers into private BUG=skia: Committed: https://skia.googlesource.com/skia/+/eedf0fb20489bc6c3706539dd6ab499f41cbe048

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -659 lines) Patch
M gyp/animator.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/core.gypi View 1 2 chunks +0 lines, -4 lines 0 comments Download
M gyp/sfnt.gyp View 1 chunk +1 line, -0 lines 0 comments Download
D include/core/SkEndian.h View 1 chunk +0 lines, -194 lines 0 comments Download
D include/core/SkFloatBits.h View 1 chunk +0 lines, -132 lines 0 comments Download
D include/core/SkFloatingPoint.h View 1 chunk +0 lines, -170 lines 0 comments Download
M include/core/SkPicture.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/core/SkScalar.h View 1 chunk +1 line, -1 line 0 comments Download
M include/core/SkTypeface.h View 1 chunk +1 line, -1 line 0 comments Download
D include/core/SkWeakRefCnt.h View 1 chunk +0 lines, -159 lines 0 comments Download
A + include/private/SkFloatBits.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + include/private/SkFloatingPoint.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + include/private/SkWeakRefCnt.h View 0 chunks +-1 lines, --1 lines 0 comments Download
M include/svg/parser/SkSVGParser.h View 1 chunk +0 lines, -1 line 0 comments Download
A + src/core/SkEndian.h View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 14 (6 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289483002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289483002/1
5 years, 4 months ago (2015-08-11 11:35:51 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/2562) Build-Win-MSVC-x86_64-Debug-Trybot on ...
5 years, 4 months ago (2015-08-11 11:39:02 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289483002/20001
5 years, 4 months ago (2015-08-11 11:46:01 UTC) #6
reed2
ptal
5 years, 4 months ago (2015-08-11 11:50:26 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-11 11:53:44 UTC) #10
mtklein
lgtm
5 years, 4 months ago (2015-08-11 14:13:43 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289483002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289483002/20001
5 years, 4 months ago (2015-08-11 14:13:54 UTC) #13
commit-bot: I haz the power
5 years, 4 months ago (2015-08-11 14:15:04 UTC) #14
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/eedf0fb20489bc6c3706539dd6ab499f41cbe048

Powered by Google App Engine
This is Rietveld 408576698