Issue 1289463002: Auto-height table cells must stop percentage resolution of child heights.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1289463002: Auto-height table cells must stop percentage resolution of child heights. (Closed)

Created:
5 years, 4 months ago by mstensho (USE GERRIT)

Modified:
5 years, 4 months ago

Reviewers:
leviw_travelin_and_unemployed

CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/remotes/origin/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Auto-height table cells must stop percentage resolution of child heights. This also needs to apply when a table cell is anonymous. The spec only mentions *blocks* when it comes to skipping anonymous objects for resolving percentages [1]. No mention of table cells anywhere. [1] http://www.w3.org/TR/2011/REC-CSS2-20110607/visuren.html#anonymous-block-level BUG=518210 R=leviw@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200337

Patch Set 1 #

Patch Set 2 : Right.. anonymous inline-blocks too. #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+23 lines, -5 lines)			Patch
A	LayoutTests/fast/table/percent-height-inside-anonymous-cell.html	View		1 chunk	+11 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/table/percent-height-inside-anonymous-cell-expected.txt	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/core/layout/LayoutBox.cpp	View	1	1 chunk	+9 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289463002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289463002/20001

5 years, 4 months ago (2015-08-11 17:45:24 UTC) #4

commit-bot: I haz the power

5 years, 4 months ago (2015-08-11 17:53:21 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200337

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages