Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(938)

Unified Diff: Source/core/editing/Position.cpp

Issue 1289423005: Move a static member function hasRenderedNonAnonymousDescendantsWithHeight() out from PositionAlgori (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: 2015-08-19T23:25:33 Rebase Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/editing/Position.h ('k') | Source/core/editing/commands/CompositeEditCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/Position.cpp
diff --git a/Source/core/editing/Position.cpp b/Source/core/editing/Position.cpp
index 8867439f73ea045d302dd24d7505f2afa5d21f2b..09e619f518de486c27d5358342186faf25c1d0f9 100644
--- a/Source/core/editing/Position.cpp
+++ b/Source/core/editing/Position.cpp
@@ -807,8 +807,9 @@ static int boundingBoxLogicalHeight(LayoutObject *o, const IntRect &rect)
return o->style()->isHorizontalWritingMode() ? rect.height() : rect.width();
}
-template <typename Strategy>
-bool PositionAlgorithm<Strategy>::hasRenderedNonAnonymousDescendantsWithHeight(LayoutObject* layoutObject)
+// TODO(yosin) We should move |hasRenderedNonAnonymousDescendantsWithHeight|
+// to "VisibleUnits.cpp" to reduce |LayoutObject| dependency in "Position.cpp"
+bool hasRenderedNonAnonymousDescendantsWithHeight(LayoutObject* layoutObject)
{
LayoutObject* stop = layoutObject->nextInPreOrderAfterChildren();
for (LayoutObject *o = layoutObject->slowFirstChild(); o && o != stop; o = o->nextInPreOrder()) {
« no previous file with comments | « Source/core/editing/Position.h ('k') | Source/core/editing/commands/CompositeEditCommand.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698