Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1289423005: Move a static member function hasRenderedNonAnonymousDescendantsWithHeight() out from PositionAlgori (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move a static member function hasRenderedNonAnonymousDescendantsWithHeight() out from PositionAlgorithm template class This patch moves |hasRenderedNonAnonymousDescendantsWithHeight()| out from |PositionAlgorithm| template class to simplify |PositionAlgorithm| class for improving code health, since |hasRenderedNonAnonymousDescendantsWithHeight()| doesn't depend on |Strategy| template parameter. BUG=518738 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200830

Patch Set 1 : 2015-08-19T17:41:46 #

Patch Set 2 : 2015-08-19T23:25:33　Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M Source/core/editing/Position.h View 1 2 chunks +4 lines, -1 line 0 comments Download
M Source/core/editing/Position.cpp View 1 1 chunk +3 lines, -2 lines 0 comments Download
M Source/core/editing/commands/CompositeEditCommand.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289423005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289423005/1
5 years, 4 months ago (2015-08-19 08:44:01 UTC) #2
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-19 09:37:18 UTC) #4
hajimehoshi
lgtm
5 years, 4 months ago (2015-08-19 10:19:46 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/100374)
5 years, 4 months ago (2015-08-19 10:41:37 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289423005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289423005/1
5 years, 4 months ago (2015-08-19 12:55:27 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/95268)
5 years, 4 months ago (2015-08-19 14:03:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289423005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289423005/20001
5 years, 4 months ago (2015-08-19 14:26:06 UTC) #14
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 16:02:24 UTC) #15
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200830

Powered by Google App Engine
This is Rietveld 408576698