Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1289423003: Reland: 2D canvas: remain in deferred rendering mode with canvas to canvas drawImage (Closed)

Created:
5 years, 4 months ago by Justin Novosad
Modified:
5 years, 4 months ago
Reviewers:
Stephen White
CC:
blink-reviews, krit, blink-reviews-html_chromium.org, drott+blinkwatch_chromium.org, dshwang, pdr+graphicswatchlist_chromium.org, Justin Novosad, jbroman, danakj, dglazkov+blink, Rik, f(malita), Stephen Chennney, rwlbuis
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Reland: 2D canvas: remain in deferred rendering mode with canvas to canvas drawImage If the source canvas is not animated, no need to exit deferred rendering because there is no risk of memory bloat due to snapshotting. Fixed reson for original revert: m_snapshotState was not initialized BUG=521001, 521732 NOTRY=true Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200771

Patch Set 1 #

Patch Set 2 : fixed init oerder error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -11 lines) Patch
M Source/core/html/HTMLCanvasElement.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/HTMLCanvasElement.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M Source/modules/canvas2d/CanvasRenderingContext2D.cpp View 2 chunks +15 lines, -6 lines 0 comments Download
M Source/platform/graphics/ImageBuffer.h View 2 chunks +8 lines, -1 line 0 comments Download
M Source/platform/graphics/ImageBuffer.cpp View 1 3 chunks +13 lines, -4 lines 0 comments Download

Depends on Patchset:

Issue 895153002 Patch 100001

Messages

Total messages: 15 (7 generated)
Justin Novosad
PTAL
5 years, 4 months ago (2015-08-17 19:16:28 UTC) #2
Stephen White
LGTM
5 years, 4 months ago (2015-08-17 19:17:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289423003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289423003/20001
5 years, 4 months ago (2015-08-17 19:26:09 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/99183)
5 years, 4 months ago (2015-08-17 22:30:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289423003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289423003/20001
5 years, 4 months ago (2015-08-18 18:09:21 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/94848)
5 years, 4 months ago (2015-08-18 21:16:57 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289423003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289423003/20001
5 years, 4 months ago (2015-08-19 00:52:24 UTC) #14
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 00:57:00 UTC) #15
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200771

Powered by Google App Engine
This is Rietveld 408576698