Switch global error menu icon to vectorized MD asset

chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm

Index: chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
diff --git a/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm b/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
index 5e9f500cf5d7bb98f5cb91e0cfe596c895420235..ae45ebd6271630a24750b204a263b382250bfcf2 100644
--- a/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
+++ b/chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
@@ -21,6 +21,7 @@
 #include "chrome/browser/command_updater.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/search/search.h"
+#include "chrome/browser/sync/sync_global_error_factory.h"
 #include "chrome/browser/themes/theme_service.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_commands.h"
@@ -246,6 +247,8 @@ class NotificationBridge : public WrenchMenuBadgeController::Delegate {
                              profile:profile
                              browser:browser
                         nibFileNamed:@"Toolbar"])) {
+    // Start global error services now so we badge the menu correctly.
+    SyncGlobalErrorFactory::GetForProfile(profile);

[Evan Stade, 2015/09/03 00:47:12]

groby, please review changes to this file. This is similar to what we do in
toolbar_view.cc[1]

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...

[groby-ooo-7-16, 2015/09/03 17:19:39]

Question: Would it be better to hoist that up to the browser constructor, so we
can share? (or to CreateBrowserWindow?)

[Evan Stade, 2015/09/03 17:51:28]

In theory, yes, but on Views we apparently only do it if there's no ash shell
(so not cros and not win metro mode), so I think it would be tricky to get it
right in shared code.

   }
   return self;
 }