Switch global error menu icon to vectorized MD asset

Switch global error menu icon to vectorized MD asset

visible e.g. with the sync passphrase global error

BUG=505953
Committed: https://crrev.com/fd1a6fd38213817eb7d7e8d0df6c82fc9223ee0c
Cr-Commit-Position: refs/heads/master@{#347188}

[Evan Stade, 2015-08-18 19:16:52]

estade@chromium.org changed reviewers:
+ sky@chromium.org

[Evan Stade, 2015-08-18 19:16:52]

one or two more places still use IDR_INPUT_ALERT_MENU and will need to be
updated before we can remove the asset.

[Evan Stade, 2015-08-18 19:17:44]

On 2015/08/18 19:16:52, Evan Stade wrote:
> one or two more places still use IDR_INPUT_ALERT_MENU and will need to be
> updated before we can remove the asset.

p.s. this changes the roundrect ! to a triangle !, but I sent a screenshot to
sgabriel and he approved

[sky, 2015-08-18 20:49:34]

LGTM

[Evan Stade, 2015-08-18 21:59:10]

The CQ bit was checked by estade@chromium.org

[commit-bot: I haz the power, 2015-08-18 21:59:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1289413003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1289413003/40001

[commit-bot: I haz the power, 2015-08-18 22:02:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-18 22:02:05]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Evan Stade, 2015-08-20 20:56:14]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2015-08-20 20:56:14]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org
Link to the patchset: https://codereview.chromium.org/1289413003/#ps80001
(title: ".")

[commit-bot: I haz the power, 2015-08-20 20:57:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1289413003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1289413003/80001

[commit-bot: I haz the power, 2015-08-20 21:30:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-20 21:30:35]

Try jobs failed on following builders:
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)

[Evan Stade, 2015-08-27 19:55:06]

estade@chromium.org changed reviewers:
+ rogerta@chromium.org

[Evan Stade, 2015-08-27 19:55:07]

since I had to revert the CL that deleted signin global error, I had to rebase.
From that change, I was able to salvage some code deletions in wrench menu model
which shouldn't affect the OSX app menu. +rogerta, could you take a look?

[Roger Tawa OOO till Jul 10th, 2015-08-27 20:24:15]

lgtm with one comment below.

https://codereview.chromium.org/1289413003/diff/100001/chrome/browser/ui/tool...
File chrome/browser/ui/toolbar/wrench_menu_model.cc (right):

https://codereview.chromium.org/1289413003/diff/100001/chrome/browser/ui/tool...
chrome/browser/ui/toolbar/wrench_menu_model.cc:953:
browser_->profile()->GetOriginalProfile());
I think you can delete lines 949-953.

[Evan Stade, 2015-08-27 20:51:13]

https://codereview.chromium.org/1289413003/diff/100001/chrome/browser/ui/tool...
File chrome/browser/ui/toolbar/wrench_menu_model.cc (right):

https://codereview.chromium.org/1289413003/diff/100001/chrome/browser/ui/tool...
chrome/browser/ui/toolbar/wrench_menu_model.cc:953:
browser_->profile()->GetOriginalProfile());
On 2015/08/27 20:24:15, Roger Tawa wrote:
> I think you can delete lines 949-953.

you're right, I might be able to, but I'm worried it will break mac again, so
I'll have to double check that.

[Evan Stade, 2015-09-01 22:27:05]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-01 22:27:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1289413003/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1289413003/160001

[commit-bot: I haz the power, 2015-09-01 22:42:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-01 22:42:31]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_compile_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)

[Evan Stade, 2015-09-02 16:54:15]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-02 16:55:17]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1289413003/180001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1289413003/180001

[commit-bot: I haz the power, 2015-09-02 17:45:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-02 17:45:17]

Dry run: This issue passed the CQ dry run.

[Evan Stade, 2015-09-03 00:47:11]

estade@chromium.org changed reviewers:
+ groby@chromium.org

[Evan Stade, 2015-09-03 00:47:12]

https://codereview.chromium.org/1289413003/diff/200001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm (right):

https://codereview.chromium.org/1289413003/diff/200001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm:251:
SyncGlobalErrorFactory::GetForProfile(profile);
groby, please review changes to this file. This is similar to what we do in
toolbar_view.cc[1]

[1]
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...

[Evan Stade, 2015-09-03 00:47:21]

The CQ bit was checked by estade@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-09-03 00:47:52]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1289413003/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1289413003/200001

[commit-bot: I haz the power, 2015-09-03 02:35:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-03 02:35:04]

Dry run: This issue passed the CQ dry run.

[groby-ooo-7-16, 2015-09-03 17:19:39]

c/b/ui/cocoa LGTM unless the move to platform neutral code makes sense.

https://codereview.chromium.org/1289413003/diff/200001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm (right):

https://codereview.chromium.org/1289413003/diff/200001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm:251:
SyncGlobalErrorFactory::GetForProfile(profile);
On 2015/09/03 00:47:12, Evan Stade wrote:
> groby, please review changes to this file. This is similar to what we do in
> toolbar_view.cc[1]
> 
> [1]
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...

Question: Would it be better to hoist that up to the browser constructor, so we
can share? (or to CreateBrowserWindow?)

[Evan Stade, 2015-09-03 17:51:28]

https://codereview.chromium.org/1289413003/diff/200001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm (right):

https://codereview.chromium.org/1289413003/diff/200001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm:251:
SyncGlobalErrorFactory::GetForProfile(profile);
On 2015/09/03 17:19:39, groby wrote:
> On 2015/09/03 00:47:12, Evan Stade wrote:
> > groby, please review changes to this file. This is similar to what we do in
> > toolbar_view.cc[1]
> > 
> > [1]
> >
>
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/...
> 
> Question: Would it be better to hoist that up to the browser constructor, so
we
> can share? (or to CreateBrowserWindow?)

In theory, yes, but on Views we apparently only do it if there's no ash shell
(so not cros and not win metro mode), so I think it would be tricky to get it
right in shared code.

[Evan Stade, 2015-09-03 17:51:33]

The CQ bit was checked by estade@chromium.org

[Evan Stade, 2015-09-03 17:51:33]

The patchset sent to the CQ was uploaded after l-g-t-m from sky@chromium.org,
rogerta@chromium.org
Link to the patchset: https://codereview.chromium.org/1289413003/#ps200001
(title: "kick signin error service on mac")

[commit-bot: I haz the power, 2015-09-03 17:53:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1289413003/200001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1289413003/200001

[commit-bot: I haz the power, 2015-09-03 18:01:25]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2015-09-03 18:02:31]

Patchset 11 (id:??) landed as
https://crrev.com/fd1a6fd38213817eb7d7e8d0df6c82fc9223ee0c
Cr-Commit-Position: refs/heads/master@{#347188}