Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(501)

Issue 12894: * Updated mozilla.status to exclude new incompatible tests. (Closed)

Created:
12 years ago by Lasse Reichstein
Modified:
9 years, 6 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Removed lots of new mozilla tests depending on "options" function. Options is used to exclude tests when running jit.

Patch Set 1 #

Patch Set 2 : Added options emulation for mozilla tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -11 lines) Patch
M test/mozilla/mozilla.status View 1 9 chunks +35 lines, -8 lines 0 comments Download
A test/mozilla/mozilla-shell-emulation.js View 1 chunk +37 lines, -0 lines 0 comments Download
M test/mozilla/testcfg.py View 3 chunks +5 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein
Small review.
12 years ago (2008-12-03 08:48:51 UTC) #1
Erik Corry
http://codereview.chromium.org/12894/diff/1/2 File test/mozilla/mozilla.status (right): http://codereview.chromium.org/12894/diff/1/2#newcode210 Line 210: # toPrecision argument restricted to range 1..21 in ...
12 years ago (2008-12-03 08:55:03 UTC) #2
Erik Corry
LGTM
12 years ago (2008-12-03 09:18:50 UTC) #3
Lasse Reichstein
12 years ago (2008-12-03 12:25:51 UTC) #4
http://codereview.chromium.org/12894/diff/1/2
File test/mozilla/mozilla.status (right):

http://codereview.chromium.org/12894/diff/1/2#newcode238
Line 238: js1_5/extensions/regress-459606: FAIL_OK
It uses "toSource".

Powered by Google App Engine
This is Rietveld 408576698