Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1289373004: [API] Check for NULL external data pointer in ArrayBuffer::New() (Closed)

Created:
5 years, 4 months ago by Jakob Kummerow
Modified:
5 years, 4 months ago
Reviewers:
Camillo Bruni
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[API] Check for NULL external data pointer in ArrayBuffer::New() Embedders must not provide invalid pointers for external backing stores. BUG=chromium:522128 LOG=n R=cbruni@chromium.org Committed: https://crrev.com/7fc7957be57d1cdfb0b7e1d76bdee78f4699774f Cr-Commit-Position: refs/heads/master@{#30243}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M src/api.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Jakob Kummerow
Please take a look, and CQ it if you like it.
5 years, 4 months ago (2015-08-18 16:47:22 UTC) #1
Camillo Bruni
lgtm
5 years, 4 months ago (2015-08-19 05:40:15 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289373004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289373004/1
5 years, 4 months ago (2015-08-19 05:40:22 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-19 06:30:47 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 06:31:09 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7fc7957be57d1cdfb0b7e1d76bdee78f4699774f
Cr-Commit-Position: refs/heads/master@{#30243}

Powered by Google App Engine
This is Rietveld 408576698