Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Issue 1289343006: Expose outgoingReferrer() to WebDocument. (Closed)

Created:
5 years, 4 months ago by dominickn
Modified:
5 years, 4 months ago
Reviewers:
Mike West
CC:
blink-reviews, chrome-apps-syd-reviews_chromium.org, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Expose outgoingReferrer() to WebDocument. This CL exposes the outgoingReferrer() method on the public WebDocument interface. This allows Chromium to access a page's outgoing referrer (stripped of undesirable information) via WebDocument. BUG=522734 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200946

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M Source/web/WebDocument.cpp View 1 chunk +5 lines, -0 lines 1 comment Download
M public/web/WebDocument.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
dominickn
PTAL, thanks!
5 years, 4 months ago (2015-08-20 00:18:56 UTC) #2
Mike West
LGTM, thanks! https://codereview.chromium.org/1289343006/diff/1/Source/web/WebDocument.cpp File Source/web/WebDocument.cpp (right): https://codereview.chromium.org/1289343006/diff/1/Source/web/WebDocument.cpp#newcode267 Source/web/WebDocument.cpp:267: return WebString(unwrap<Document>()->outgoingReferrer()); Nit: Can this be `constUnwrap`?
5 years, 4 months ago (2015-08-20 20:07:25 UTC) #3
dominickn
On 2015/08/20 20:07:25, Mike West (traveling) wrote: > LGTM, thanks! > > https://codereview.chromium.org/1289343006/diff/1/Source/web/WebDocument.cpp > File ...
5 years, 4 months ago (2015-08-20 21:41:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289343006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289343006/1
5 years, 4 months ago (2015-08-20 21:42:37 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 00:56:07 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200946

Powered by Google App Engine
This is Rietveld 408576698