Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Unified Diff: chrome/installer/util/shell_util.h

Issue 1289333005: Change shortcut install location to non-subdir. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: test improvements Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/shell_util.h
diff --git a/chrome/installer/util/shell_util.h b/chrome/installer/util/shell_util.h
index 5b35e1185ce36f38aed6962fecd9b8ffd16e881b..46a8998072a6b9e5da273d42703074360b297bf5 100644
--- a/chrome/installer/util/shell_util.h
+++ b/chrome/installer/util/shell_util.h
@@ -54,7 +54,7 @@ class ShellUtil {
SHORTCUT_LOCATION_DESKTOP = SHORTCUT_LOCATION_FIRST,
SHORTCUT_LOCATION_QUICK_LAUNCH,
SHORTCUT_LOCATION_START_MENU_ROOT,
- SHORTCUT_LOCATION_START_MENU_CHROME_DIR,
+ SHORTCUT_LOCATION_START_MENU_CHROME_DIR_DEPRECATED, // now placed in root
SHORTCUT_LOCATION_START_MENU_CHROME_APPS_DIR,
SHORTCUT_LOCATION_TASKBAR_PINS, // base::win::VERSION_WIN7 +
SHORTCUT_LOCATION_APP_SHORTCUTS, // base::win::VERSION_WIN8 +
@@ -330,6 +330,15 @@ class ShellUtil {
ShellChange level,
base::FilePath* path);
+ // Move an existing shortcut from |old_location| to |new_location| for the
+ // set |shortcut_level|.
grt (UTC plus 2) 2015/10/19 17:28:45 please add to the comment that the folder at |old_
bcwhite 2015/10/20 16:02:13 Done.
+ static bool ShellUtil::MoveExistingShortcut(
grt (UTC plus 2) 2015/10/19 17:28:45 could you add a unittest for this?
grt (UTC plus 2) 2015/10/19 17:28:45 remove ShellUtil::
bcwhite 2015/10/20 16:02:13 Done.
bcwhite 2015/10/20 16:02:13 Done. (here and elsewhere)
+ ShellUtil::ShortcutLocation old_location,
+ ShellUtil::ShortcutLocation new_location,
+ BrowserDistribution* dist,
+ ShellUtil::ShellChange shortcut_level,
+ const ShellUtil::ShortcutProperties& properties);
+
// Updates shortcut in |location| (or creates it if |options| specify
// SHELL_SHORTCUT_CREATE_ALWAYS).
// |dist| gives the type of browser distribution currently in use.

Powered by Google App Engine
This is Rietveld 408576698