Change shortcut install location to non-subdir.

chrome/installer/setup/install_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <objbase.h>
 
 #include <string>
 
 #include "base/base_paths.h"
 #include "base/files/file_path.h"
@@ skipping 108 matching lines @@
         installer::kLnkExt);
     base::string16 alternate_shortcut_name(
         dist_->GetShortcutName(BrowserDistribution::SHORTCUT_CHROME_ALTERNATE) +
         installer::kLnkExt);
 
     user_desktop_shortcut_ =
         fake_user_desktop_.path().Append(shortcut_name);
     user_quick_launch_shortcut_ =
         fake_user_quick_launch_.path().Append(shortcut_name);
     user_start_menu_shortcut_ =
+        fake_start_menu_.path().Append(shortcut_name);
+    user_start_menu_subdir_shortcut_ =
         fake_start_menu_.path().Append(
             dist_->GetStartMenuShortcutSubfolder(
                 BrowserDistribution::SUBFOLDER_CHROME))
         .Append(shortcut_name);
     system_desktop_shortcut_ =
         fake_common_desktop_.path().Append(shortcut_name);
     system_start_menu_shortcut_ =
-        fake_common_start_menu_.path().Append(
-            dist_->GetStartMenuShortcutSubfolder(
-                BrowserDistribution::SUBFOLDER_CHROME))
-        .Append(shortcut_name);
+        fake_common_start_menu_.path().Append(shortcut_name);
     user_alternate_desktop_shortcut_ =
         fake_user_desktop_.path().Append(alternate_shortcut_name);
   }
 
   void TearDown() override {
     // Try to unpin potentially pinned shortcuts (although pinning isn't tested,
     // the call itself might still have pinned the Start Menu shortcuts).
     base::win::UnpinShortcutFromTaskbar(user_start_menu_shortcut_);
     base::win::UnpinShortcutFromTaskbar(system_start_menu_shortcut_);
     base::win::UnpinShortcutFromStart(user_start_menu_shortcut_);
+    base::win::UnpinShortcutFromStart(user_start_menu_subdir_shortcut_);
     base::win::UnpinShortcutFromStart(system_start_menu_shortcut_);
     CoUninitialize();
   }
 
   installer::MasterPreferences* GetFakeMasterPrefs(
       bool do_not_create_desktop_shortcut,
       bool do_not_create_quick_launch_shortcut,
       bool alternate_desktop_shortcut) {
     const struct {
       const char* pref_name;
@@ skipping 12 matching lines @@
       master_prefs += (i == 0 ? "\"" : ",\"");
       master_prefs += desired_prefs[i].pref_name;
       master_prefs += "\":";
       master_prefs += desired_prefs[i].is_desired ? "true" : "false";
     }
     master_prefs += "}}";
 
     return new installer::MasterPreferences(master_prefs);
   }
 
+  void MigrationTest(installer::InstallShortcutOperation shortcut_operation);
+
   base::win::ShortcutProperties expected_properties_;
   base::win::ShortcutProperties expected_start_menu_properties_;
 
   BrowserDistribution* dist_;
   base::FilePath chrome_exe_;
   scoped_ptr<installer::Product> product_;
   scoped_ptr<installer::MasterPreferences> prefs_;
 
   base::ScopedTempDir temp_dir_;
   base::ScopedTempDir fake_user_desktop_;
   base::ScopedTempDir fake_common_desktop_;
   base::ScopedTempDir fake_user_quick_launch_;
   base::ScopedTempDir fake_start_menu_;
   base::ScopedTempDir fake_common_start_menu_;
   scoped_ptr<base::ScopedPathOverride> user_desktop_override_;
   scoped_ptr<base::ScopedPathOverride> common_desktop_override_;
   scoped_ptr<base::ScopedPathOverride> user_quick_launch_override_;
   scoped_ptr<base::ScopedPathOverride> start_menu_override_;
   scoped_ptr<base::ScopedPathOverride> common_start_menu_override_;
 
   base::FilePath user_desktop_shortcut_;
   base::FilePath user_quick_launch_shortcut_;
   base::FilePath user_start_menu_shortcut_;
+  base::FilePath user_start_menu_subdir_shortcut_;
   base::FilePath system_desktop_shortcut_;
   base::FilePath system_start_menu_shortcut_;
   base::FilePath user_alternate_desktop_shortcut_;
 };
 
 }  // namespace
 
 // Test that VisualElementsManifest.xml is not created when VisualElements are
 // not present.
 TEST_F(CreateVisualElementsManifestTest, VisualElementsManifestNotCreated) {
@@ skipping 155 matching lines @@
   ASSERT_TRUE(base::CreateDirectory(user_start_menu_shortcut_.DirName()));
 
   installer::CreateOrUpdateShortcuts(
       chrome_exe_, *product_, *prefs_, installer::CURRENT_USER,
       installer::INSTALL_SHORTCUT_REPLACE_EXISTING);
   base::win::ValidateShortcut(user_desktop_shortcut_, expected_properties_);
   ASSERT_FALSE(base::PathExists(user_quick_launch_shortcut_));
   ASSERT_FALSE(base::PathExists(user_start_menu_shortcut_));
 }
 
+void InstallShortcutTest::MigrationTest(

[gab, 2015/10/13 19:35:09]

s/MigrationTest/MigrateAwayFromDeprecatedStartMenuSubfolderTest/

(or something more precise along those lines)

[bcwhite, 2015/10/15 18:29:35]

Done.

+    installer::InstallShortcutOperation shortcut_operation) {
+  base::win::ShortcutProperties dummy_properties;
+  base::FilePath dummy_target;
+  ASSERT_TRUE(base::CreateTemporaryFileInDir(temp_dir_.path(), &dummy_target));
+  dummy_properties.set_target(expected_properties_.target);
+  dummy_properties.set_working_dir(fake_user_desktop_.path());
+  dummy_properties.set_arguments(L"--dummy --args");
+  dummy_properties.set_app_id(L"El.Dummiest");
+
+  ASSERT_TRUE(base::CreateDirectory(
+                  user_start_menu_subdir_shortcut_.DirName()));
+  ASSERT_FALSE(base::PathExists(user_start_menu_subdir_shortcut_));
+  ASSERT_TRUE(base::win::CreateOrUpdateShortcutLink(
+                  user_start_menu_subdir_shortcut_, dummy_properties,
+                  base::win::SHORTCUT_CREATE_ALWAYS));
+  ASSERT_TRUE(base::PathExists(user_start_menu_subdir_shortcut_));
+  ASSERT_FALSE(base::PathExists(user_start_menu_shortcut_));
+
+  installer::CreateOrUpdateShortcuts(
+      chrome_exe_, *product_, *prefs_, installer::CURRENT_USER,
+      shortcut_operation);
+  ASSERT_FALSE(base::PathExists(user_start_menu_subdir_shortcut_));
+  ASSERT_TRUE(base::PathExists(user_start_menu_shortcut_));
+}
+
+TEST_F(InstallShortcutTest, MigrateExistingDuringUpdate) {
+  MigrationTest(installer::INSTALL_SHORTCUT_REPLACE_EXISTING);
+}
+
+TEST_F(InstallShortcutTest, MigrateExistingDuringInstall) {
+  MigrationTest(installer::INSTALL_SHORTCUT_CREATE_ALL);
+}

[gab, 2015/10/13 19:35:09]

I still think it'd be better to TEST_P to test across all install combinations
(INSTALL_SHORTCUT_* and user/system), but I could live with this as a compromise
if the other one is too complex.

[bcwhite, 2015/10/15 18:29:35]

Done.

+
 TEST_F(InstallShortcutTest, CreateIfNoSystemLevelAllSystemShortcutsExist) {
   base::win::ShortcutProperties dummy_properties;
   base::FilePath dummy_target;
   ASSERT_TRUE(base::CreateTemporaryFileInDir(temp_dir_.path(), &dummy_target));
   dummy_properties.set_target(dummy_target);
 
   ASSERT_TRUE(base::win::CreateOrUpdateShortcutLink(
                   system_desktop_shortcut_, dummy_properties,
                   base::win::SHORTCUT_CREATE_ALWAYS));
   ASSERT_TRUE(base::CreateDirectory(
@@ skipping 50 matching lines @@
   installer::EscapeXmlAttributeValueInSingleQuotes(&val);
   ASSERT_STREQ(kExpectedEscapedVal, val.c_str());
 }
 
 TEST(EscapeXmlAttributeValueTest, DontEscapeNormalValue) {
   base::string16 val(L"Google Chrome");
   static const wchar_t kExpectedEscapedVal[] = L"Google Chrome";
   installer::EscapeXmlAttributeValueInSingleQuotes(&val);
   ASSERT_STREQ(kExpectedEscapedVal, val.c_str());
 }