Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1289333002: Rebase layout tests after changes to AARect (Closed)

Created:
5 years, 4 months ago by joshua.litt
Modified:
5 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rebase layout tests after changes to AARect BUG=521012 Committed: https://crrev.com/fde02559a6b514c66cc7a56b2b7b94a81ea3d07f Cr-Commit-Position: refs/heads/master@{#343427}

Patch Set 1 #

Patch Set 2 : tweak #

Patch Set 3 : adding com #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M skia/skia_test_expectations.txt View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
joshualitt
ptal
5 years, 4 months ago (2015-08-14 16:31:11 UTC) #2
robertphillips
lgtm
5 years, 4 months ago (2015-08-14 16:31:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289333002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289333002/1
5 years, 4 months ago (2015-08-14 17:29:18 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-14 17:50:47 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fde02559a6b514c66cc7a56b2b7b94a81ea3d07f Cr-Commit-Position: refs/heads/master@{#343427}
5 years, 4 months ago (2015-08-14 17:51:17 UTC) #7
yurys
5 years, 4 months ago (2015-08-14 18:07:39 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1295833002/ by yurys@chromium.org.

The reason for reverting is: Caused lint errors on WebKit Mac

http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Mac10.8/builds/....

Powered by Google App Engine
This is Rietveld 408576698