Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 128933005: Remove the base.gyp dependency from system.gyp (Closed)

Created:
6 years, 11 months ago by jiayl
Modified:
6 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove the base.gyp dependency from system.gyp The dependency is unnecessary and causes build error in the standalone webrtc project due to missing base.gyp when SCTP is enabled (it depends on usrsctp.gyp, which depends on system.gyp). All system.typ needs from base.gyp is the "include_dirs" pointing to ".." relative to "base". So we can remove the dependency on base.gyp and add "include_dirs":["../.."] instead. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243863

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M build/linux/system.gyp View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jiayl
PTAL. Thanks!
6 years, 11 months ago (2014-01-08 23:47:27 UTC) #1
Ami GONE FROM CHROMIUM
LGTM
6 years, 11 months ago (2014-01-08 23:53:02 UTC) #2
jiayl
Peter, could you take a look?
6 years, 11 months ago (2014-01-08 23:55:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jiayl@chromium.org/128933005/20002
6 years, 11 months ago (2014-01-09 00:19:41 UTC) #4
Peter Lundblad
lgtm
6 years, 11 months ago (2014-01-09 00:25:13 UTC) #5
darin (slow to review)
OK, LGTM
6 years, 11 months ago (2014-01-09 08:11:28 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 12:22:48 UTC) #7
Message was sent while issue was closed.
Change committed as 243863

Powered by Google App Engine
This is Rietveld 408576698