Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Unified Diff: service/datastore/multiarg.go

Issue 1289323002: Fix miscellaneous prod bugs. (Closed) Base URL: https://github.com/luci/gae@master
Patch Set: Moar fixes. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « service/datastore/checkfilter.go ('k') | service/datastore/pls.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: service/datastore/multiarg.go
diff --git a/service/datastore/multiarg.go b/service/datastore/multiarg.go
index 3efa1493df86692ed1947c2985ba17e753f54b46..091596b4884e451b02f58b22e35b999e24215af5 100644
--- a/service/datastore/multiarg.go
+++ b/service/datastore/multiarg.go
@@ -267,7 +267,8 @@ func mkPLSName(o interface{}) (PropertyLoadSaver, string) {
return pls, pls.o.Type().Name()
}
if pls, ok := o.(PropertyLoadSaver); ok {
- return pls, ""
+ v, _ := getPLSValue(o)
+ return pls, v.Type().Name()
iannucci 2015/08/15 02:23:53 This looks really wrong to me. We already see if i
dnj (Google) 2015/08/15 02:32:32 The problem occurs when I implement a custom Prope
}
pls := GetPLS(o)
name := pls.(*structPLS).o.Type().Name()
« no previous file with comments | « service/datastore/checkfilter.go ('k') | service/datastore/pls.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698