Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(832)

Unified Diff: service/datastore/properties_test.go

Issue 1289323002: Fix miscellaneous prod bugs. (Closed) Base URL: https://github.com/luci/gae@master
Patch Set: Rebase. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « service/datastore/properties.go ('k') | service/info/interface.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: service/datastore/properties_test.go
diff --git a/service/datastore/properties_test.go b/service/datastore/properties_test.go
index 615ac1b29438712949e57c79cc38eb6399f784a9..c535229306a6d9c2f65a8e61544b047b15c8cdaa 100644
--- a/service/datastore/properties_test.go
+++ b/service/datastore/properties_test.go
@@ -94,7 +94,11 @@ func TestProperties(t *testing.T) {
})
Convey("invalid time", func() {
pv := Property{}
- err := pv.SetValue(time.Now(), ShouldIndex)
+ loc, err := time.LoadLocation("America/Los_Angeles")
+ So(err, ShouldBeNil)
+ t := time.Date(1970, 1, 1, 0, 0, 0, 0, loc)
+
+ err = pv.SetValue(t, ShouldIndex)
So(err.Error(), ShouldContainSubstring, "time value has wrong Location")
err = pv.SetValue(time.Unix(math.MaxInt64, 0).UTC(), ShouldIndex)
« no previous file with comments | « service/datastore/properties.go ('k') | service/info/interface.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698