Fix miscellaneous prod bugs.

service/datastore/checkfilter.go

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package datastore
 
 import (
         "fmt"
 
         "github.com/luci/gae/service/info"
@@ skipping 99 matching lines @@
                 for _, err := range me.(errors.MultiError) {
                         cb(err)
                 }
                 return nil
         }
         return tcf.RawInterface.DeleteMulti(keys, cb)
 }
 
 func applyCheckFilter(c context.Context, i RawInterface) RawInterface {
         inf := info.Get(c)
-        return &checkFilter{i, inf.AppID(), inf.GetNamespace()}
+        aid := inf.AppID()
+        if inf.IsDevAppServer() {
+                aid = "dev~" + aid
+        }

[iannucci, 2015/08/15 21:50:54]

This is the wrong place to apply this. memory.info.AppID should return this
directly.

[dnj (Google), 2015/08/16 06:11:06]

The actual AppID (as returned by appengine.AppID()) does _not_ have the "dev~"
prefix. It's just prepended to the keys generated by "appengine". Adjusting the
formal AppID would be wrong in this case.

What's happening is:
1) GAE is asking "appengine" layer to create a key. "appengine" does so, using
AppID and prepending "dev~".
2) Fine so far, GAE translates that key into a valid GAE key, cool.
3) checkfilter says, "hey key, you're supposed to have info.AppID(). You fail
teh chex."

So everything is great except for checkFilter's idea of what the AppID should
be. That's why I put this logic here.

+        return &checkFilter{i, aid, inf.GetNamespace()}
 }