Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Side by Side Diff: service/datastore/context_test.go

Issue 1289323002: Fix miscellaneous prod bugs. (Closed) Base URL: https://github.com/luci/gae@master
Patch Set: Rebase. Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « service/datastore/checkfilter_test.go ('k') | service/datastore/datastore_test.go » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 package datastore 5 package datastore
6 6
7 import ( 7 import (
8 "testing" 8 "testing"
9 9
10 "github.com/luci/gae/service/info" 10 "github.com/luci/gae/service/info"
11 . "github.com/smartystreets/goconvey/convey" 11 . "github.com/smartystreets/goconvey/convey"
12 "golang.org/x/net/context" 12 "golang.org/x/net/context"
13 ) 13 )
14 14
15 type fakeInfo struct{ info.Interface } 15 type fakeInfo struct{ info.Interface }
16 16
17 func (fakeInfo) GetNamespace() string { return "ns" } 17 func (fakeInfo) GetNamespace() string { return "ns" }
18 func (fakeInfo) AppID() string { return "aid" } 18 func (fakeInfo) AppID() string { return "aid" }
19 func (fakeInfo) FullyQualifiedAppID() string { return "s~aid" }
19 20
20 type fakeService struct{ RawInterface } 21 type fakeService struct{ RawInterface }
21 22
22 type fakeFilt struct{ RawInterface } 23 type fakeFilt struct{ RawInterface }
23 24
24 func (fakeFilt) NewKey(kind, stringID string, intID int64, parent Key) Key { 25 func (fakeFilt) NewKey(kind, stringID string, intID int64, parent Key) Key {
25 return mkKey("aid", "ns", "filteredKind", "") 26 return mkKey("aid", "ns", "filteredKind", "")
26 } 27 }
27 28
28 func TestServices(t *testing.T) { 29 func TestServices(t *testing.T) {
29 t.Parallel() 30 t.Parallel()
30 31
31 Convey("Test service interfaces", t, func() { 32 Convey("Test service interfaces", t, func() {
32 c := context.Background() 33 c := context.Background()
33 Convey("without adding anything", func() { 34 Convey("without adding anything", func() {
34 So(GetRaw(c), ShouldBeNil) 35 So(GetRaw(c), ShouldBeNil)
35 }) 36 })
36 37
37 Convey("adding a basic implementation", func() { 38 Convey("adding a basic implementation", func() {
38 c = SetRaw(info.Set(c, fakeInfo{}), fakeService{}) 39 c = SetRaw(info.Set(c, fakeInfo{}), fakeService{})
39 40
40 Convey("lets you pull them back out", func() { 41 Convey("lets you pull them back out", func() {
41 » » » » So(GetRaw(c), ShouldResemble, &checkFilter{fakeS ervice{}, "aid", "ns"}) 42 » » » » So(GetRaw(c), ShouldResemble, &checkFilter{fakeS ervice{}, "s~aid", "ns"})
42 }) 43 })
43 44
44 Convey("and lets you add filters", func() { 45 Convey("and lets you add filters", func() {
45 c = AddRawFilters(c, func(ic context.Context, rd s RawInterface) RawInterface { 46 c = AddRawFilters(c, func(ic context.Context, rd s RawInterface) RawInterface {
46 return fakeFilt{rds} 47 return fakeFilt{rds}
47 }) 48 })
48 49
49 k := Get(c).NewKey("Kind", "", 1, nil) 50 k := Get(c).NewKey("Kind", "", 1, nil)
50 So(k.Kind(), ShouldEqual, "filteredKind") 51 So(k.Kind(), ShouldEqual, "filteredKind")
51 }) 52 })
52 }) 53 })
53 Convey("adding zero filters does nothing", func() { 54 Convey("adding zero filters does nothing", func() {
54 So(AddRawFilters(c), ShouldEqual, c) 55 So(AddRawFilters(c), ShouldEqual, c)
55 }) 56 })
56 }) 57 })
57 } 58 }
OLDNEW
« no previous file with comments | « service/datastore/checkfilter_test.go ('k') | service/datastore/datastore_test.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698