Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1289313003: [turbofan]: Fix bug in register hinting (Closed)

Created:
5 years, 4 months ago by danno
Modified:
5 years, 4 months ago
Reviewers:
Jarin
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan]: Fix bug in register hinting Previously, UsePositions for Phis that are constant LiveRanges which are also used as hints for other USePositions would always force-allocate the first register in the allocatable register file to that range. Committed: https://crrev.com/bfbc5e7c156aced651306645a349714f5a11e4cf Cr-Commit-Position: refs/heads/master@{#30193}

Patch Set 1 #

Patch Set 2 : Remove unneeded code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M src/compiler/register-allocator.cc View 1 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
danno
PTAL
5 years, 4 months ago (2015-08-17 12:12:36 UTC) #2
Jarin
lgtm. Thanks!
5 years, 4 months ago (2015-08-17 12:16:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1289313003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1289313003/20001
5 years, 4 months ago (2015-08-17 12:41:55 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-17 12:44:05 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 12:44:11 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bfbc5e7c156aced651306645a349714f5a11e4cf
Cr-Commit-Position: refs/heads/master@{#30193}

Powered by Google App Engine
This is Rietveld 408576698